linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
	irogers@google.com, namhyung@kernel.org
Cc: atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
	linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
	disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	root <root@ltcden13-lp4.aus.stglabs.ibm.com>
Subject: [PATCH 0/3] Fix for shellcheck issues with version "0.6"
Date: Thu,  7 Sep 2023 22:45:37 +0530	[thread overview]
Message-ID: <20230907171540.36736-1-atrajeev@linux.vnet.ibm.com> (raw)

From: root <root@ltcden13-lp4.aus.stglabs.ibm.com>

shellcheck was run on perf tool shell scripts s a pre-requisite
to include a build option for shellcheck discussed here:
https://www.spinics.net/lists/linux-perf-users/msg25553.html

And fixes were added for the coding/formatting issues in
two patchsets:
https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atrajeev@linux.vnet.ibm.com/
https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atrajeev@linux.vnet.ibm.com/

Three additional issues are observed with shellcheck "0.6" and
this patchset covers those. With this patchset,

# for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck -S warning $F; done
# echo $?
0

Athira Rajeev (3):
  tests/shell: Fix shellcheck SC1090 to handle the location of sourced
    files
  tests/shell: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh
    tetscase
  tests/shell: Fix shellcheck warnings for SC2153 in multiple scripts

 tools/perf/tests/shell/coresight/asm_pure_loop.sh            | 4 ++++
 tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh     | 4 ++++
 tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh | 4 ++++
 tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh  | 4 ++++
 tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh    | 4 ++++
 tools/perf/tests/shell/probe_vfs_getname.sh                  | 2 ++
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh        | 2 ++
 tools/perf/tests/shell/record+script_probe_vfs_getname.sh    | 2 ++
 tools/perf/tests/shell/record.sh                             | 1 +
 tools/perf/tests/shell/stat+csv_output.sh                    | 1 +
 tools/perf/tests/shell/stat+csv_summary.sh                   | 4 ++--
 tools/perf/tests/shell/stat+shadow_stat.sh                   | 4 ++--
 tools/perf/tests/shell/stat+std_output.sh                    | 1 +
 tools/perf/tests/shell/test_intel_pt.sh                      | 1 +
 tools/perf/tests/shell/trace+probe_vfs_getname.sh            | 1 +
 15 files changed, 35 insertions(+), 4 deletions(-)

-- 
2.31.1


             reply	other threads:[~2023-09-07 17:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 17:15 Athira Rajeev [this message]
2023-09-07 17:15 ` [PATCH 1/3] tests/shell: Fix shellcheck SC1090 to handle the location of sourced files Athira Rajeev
2023-09-07 17:15 ` [PATCH 2/3] tests/shell: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh tetscase Athira Rajeev
2023-09-07 17:15 ` [PATCH 3/3] tests/shell: Fix shellcheck warnings for SC2153 in multiple scripts Athira Rajeev
2023-09-07 23:50 ` [PATCH 0/3] Fix for shellcheck issues with version "0.6" Ian Rogers
2023-09-08 14:17   ` Athira Rajeev
2023-09-13  5:02     ` Athira Rajeev
2023-09-25  8:04 ` kajoljain
2023-09-27  4:27   ` Athira Rajeev
2023-09-28  3:54     ` Namhyung Kim
2023-09-30  6:02       ` Athira Rajeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907171540.36736-1-atrajeev@linux.vnet.ibm.com \
    --to=atrajeev@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=disgoel@linux.vnet.ibm.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=namhyung@kernel.org \
    --cc=root@ltcden13-lp4.aus.stglabs.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).