From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 083B5EEB565 for ; Sat, 9 Sep 2023 00:29:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=J9d3kyv7; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RjDPt4cbQz3cPY for ; Sat, 9 Sep 2023 10:29:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=J9d3kyv7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=sashal@kernel.org; receiver=lists.ozlabs.org) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RjDNw18Lpz3bWH for ; Sat, 9 Sep 2023 10:28:48 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 83154B8230B; Sat, 9 Sep 2023 00:23:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2AE9C433B8; Sat, 9 Sep 2023 00:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694219003; bh=nOrcMI1lKS5BNV4OVZj8e1ZzTNF8fetmW0+ueUueoWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J9d3kyv76oIQ/F/9kj2ETxgSO+IdtQ+OHYaBoR5LRXm3wkGbt77DaHUgzaBShmVy/ HeaowrT50bcZBELnPD56ZRy4KSuUeUkhBZi0QZdEMNr/QAnWJbCdaG6p9z1ov8tIwz J0djzapyBg1DD9+ASa0hGR4HN8QcNLRlXpYsSLHcCl0+CwACV8k5GPaqpaL+lF073C rWNQABAWcieH5VobY4pWZJHYYOdcU8+SHFYPlMnOhFHx3hsLvlk3dRG1BeMg8uoZij Pv9kv+PODRlT7VHAw/2xjb8GcfZqa1oYkjmCY+Fl6oALSZ89k9DZFRFyFx78dQx8t6 maUoOZ2h83QWg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 7/9] powerpc/pseries: fix possible memory leak in ibmebus_bus_init() Date: Fri, 8 Sep 2023 20:22:58 -0400 Message-Id: <20230909002302.3578361-7-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230909002302.3578361-1-sashal@kernel.org> References: <20230909002302.3578361-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.52 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , robh@kernel.org, sfr@canb.auug.org.au, ruanjinjie , gregkh@linuxfoundation.org, dan.j.williams@intel.com, linuxppc-dev@lists.ozlabs.org, idryomov@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: ruanjinjie [ Upstream commit afda85b963c12947e298ad85d757e333aa40fd74 ] If device_register() returns error in ibmebus_bus_init(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. As comment of device_add() says, it should call put_device() to drop the reference count that was set in device_initialize() when it fails, so the name can be freed in kobject_cleanup(). Signed-off-by: ruanjinjie Signed-off-by: Michael Ellerman Link: https://msgid.link/20221110011929.3709774-1-ruanjinjie@huawei.com Signed-off-by: Sasha Levin --- arch/powerpc/platforms/pseries/ibmebus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index a870cada7acd2..ed5fc70b7353a 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -455,6 +455,7 @@ static int __init ibmebus_bus_init(void) if (err) { printk(KERN_WARNING "%s: device_register returned %i\n", __func__, err); + put_device(&ibmebus_bus_device); bus_unregister(&ibmebus_bus_type); return err; -- 2.40.1