* [PATCH AUTOSEL 5.15 11/19] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc [not found] <20230909003903.3580394-1-sashal@kernel.org> @ 2023-09-09 0:38 ` Sasha Levin 2023-09-09 9:17 ` Sergey Shtylyov 0 siblings, 1 reply; 2+ messages in thread From: Sasha Levin @ 2023-09-09 0:38 UTC (permalink / raw) To: linux-kernel, stable Cc: Sasha Levin, Greg Kroah-Hartman, linux-usb, Ma Ke, Li Yang, linuxppc-dev From: Ma Ke <make_ruc2021@163.com> [ Upstream commit ce9daa2efc0872a9a68ea51dc8000df05893ef2e ] We should verify the bound of the array to assure that host may not manipulate the index to point past endpoint array. Signed-off-by: Ma Ke <make_ruc2021@163.com> Acked-by: Li Yang <leoyang.li@nxp.com> Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/usb/gadget/udc/fsl_qe_udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index 15db7a3868fe4..aff4050f96dd6 100644 --- a/drivers/usb/gadget/udc/fsl_qe_udc.c +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c @@ -1956,6 +1956,8 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value, } else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) { /* Get endpoint status */ int pipe = index & USB_ENDPOINT_NUMBER_MASK; + if (pipe >= USB_MAX_ENDPOINTS) + goto stall; struct qe_ep *target_ep = &udc->eps[pipe]; u16 usep; -- 2.40.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 5.15 11/19] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc 2023-09-09 0:38 ` [PATCH AUTOSEL 5.15 11/19] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc Sasha Levin @ 2023-09-09 9:17 ` Sergey Shtylyov 0 siblings, 0 replies; 2+ messages in thread From: Sergey Shtylyov @ 2023-09-09 9:17 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Greg Kroah-Hartman, linux-usb, linuxppc-dev, Ma Ke, Li Yang On 9/9/23 3:38 AM, Sasha Levin wrote: > From: Ma Ke <make_ruc2021@163.com> > > [ Upstream commit ce9daa2efc0872a9a68ea51dc8000df05893ef2e ] > > We should verify the bound of the array to assure that host > may not manipulate the index to point past endpoint array. > > Signed-off-by: Ma Ke <make_ruc2021@163.com> > Acked-by: Li Yang <leoyang.li@nxp.com> > Link: https://lore.kernel.org/r/20230628081511.186850-1-make_ruc2021@163.com > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/usb/gadget/udc/fsl_qe_udc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c > index 15db7a3868fe4..aff4050f96dd6 100644 > --- a/drivers/usb/gadget/udc/fsl_qe_udc.c > +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c > @@ -1956,6 +1956,8 @@ static void ch9getstatus(struct qe_udc *udc, u8 request_type, u16 value, > } else if ((request_type & USB_RECIP_MASK) == USB_RECIP_ENDPOINT) { > /* Get endpoint status */ > int pipe = index & USB_ENDPOINT_NUMBER_MASK; > + if (pipe >= USB_MAX_ENDPOINTS) > + goto stall; Hm, what's the earliest version of gcc needed to compile this (*if* statement amongst the variable declarations)? > struct qe_ep *target_ep = &udc->eps[pipe]; > u16 usep; > MBR, Sergey ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-09 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230909003903.3580394-1-sashal@kernel.org>
2023-09-09 0:38 ` [PATCH AUTOSEL 5.15 11/19] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc Sasha Levin
2023-09-09 9:17 ` Sergey Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).