From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E89B1C46CA1 for ; Mon, 18 Sep 2023 15:19:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=oeTvlc3P; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Rq7kW35QRz3chF for ; Tue, 19 Sep 2023 01:19:31 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=oeTvlc3P; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::72b; helo=mail-qk1-x72b.google.com; envelope-from=jgg@ziepe.ca; receiver=lists.ozlabs.org) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Rq7hx4Vzsz3cMW for ; Tue, 19 Sep 2023 01:18:09 +1000 (AEST) Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-773a0f36b4bso273252285a.0 for ; Mon, 18 Sep 2023 08:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050286; x=1695655086; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=skILK3+RqLs29/E8NIb2upQKKLhMeBuYLpBX+o8j0o8=; b=oeTvlc3PGoH0ApaXQQ3xCeU4hZahsgJWwHi9ClHdywZKWb+FieohPrk2iCp5tdkOsc 7ziDD9NaD4Wtvb2Jvi5Kyo2yJIFNlhb6LsRo1GDqr7Lg7Hj5K3gmg2HsKL39i1GK8gPY thLWBxSRLOW71DlkX4BO5TkijsDO8JB9smRqipvK3u4iF5PGXtXDi4gSfrTOrdrsPWYe rxVlPJS9wXRp1Smguvx3gk70miHbKcgp4qil1z86fW7yJxme0zn3L+yREAnvR51IG2eo Jts+M9wsmvNyAxw4Or4n9zNvdzR0OLHhCg6Vp2OCCtZSlFZtPG/jUfYfEELiR8hdhb0L sV0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050286; x=1695655086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=skILK3+RqLs29/E8NIb2upQKKLhMeBuYLpBX+o8j0o8=; b=MDAqJTVvKTASVd7gBjY74kV0ZSv1raivODVHJTHga/erdEY1VX230sD0gl4CE3RUWH ksPIR6hG9k9jnnBSSoENWZ0t/CTLPsZZlkQQMBemlJ+3F58dG26BIuOAon5LHOgQJTrp CC1bfE1/SPCw5ZbZKnep6OQ6VYfSWP6VbIcWTwI+Oh6OlwLo5tUcMzlpgEKpds9DZehZ OY8zzyEJxkmyVAQ95DMwoc6Pll1yshyt2ZR7jmHHVttXeww8e7DJP+q2UuOuhBu3f5Qx QqSiBskaaJyvq/xkXtx4FArqi3IX8tSMuYIAIoO++ZkWZeLCRi0TLW7rQC2zaL8HBPpf zEZQ== X-Gm-Message-State: AOJu0Ywxmpc4oFDZNXTV3XUDgqJ37sxiS3g0oW89HZocziWjK+qCvYeD hEt6VK7F0HnFGWT8/+JPdS7n+g== X-Google-Smtp-Source: AGHT+IEPjZK20Aqh4DOH80nyWTVB2XY8RoIapnvcyiksM3wp5qxi6JV9wSTNi2A0D4DmrBL930vlSw== X-Received: by 2002:ad4:458d:0:b0:63f:9aa3:867b with SMTP id x13-20020ad4458d000000b0063f9aa3867bmr9395365qvu.40.1695050286275; Mon, 18 Sep 2023 08:18:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id r28-20020a0cb29c000000b0063d038df3f3sm3532215qve.52.2023.09.18.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:18:05 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiG0i-0005OR-Iy; Mon, 18 Sep 2023 12:18:04 -0300 Date: Mon, 18 Sep 2023 12:18:04 -0300 From: Jason Gunthorpe To: Sean Christopherson Subject: Re: [PATCH 03/26] virt: Declare and define vfio_file_set_kvm() iff CONFIG_KVM is enabled Message-ID: <20230918151804.GH13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-4-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230916003118.2540661-4-seanjc@google.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, kvm@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-kernel@vger.kernel.org, Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Janosch Frank , Harald Freudenberger , Marc Zyngier , Huacai Chen , Halil Pasic , Andrew Thornton , Ingo Molnar , Christian Borntraeger , Jason Herne , Albert Ou , Vasily Gorbik , Venkatesh Srinivas , Heiko Carstens , Arnaldo Carvalho de Melo , Alex Williamson , Borislav Petkov , And y Lutomirski , Paul Walmsley , kvmarm@lists.linux.dev, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Tony Krowiak , Anish Ghulati , linux-mips@vger.kernel.org, Oliver Upton , linux-perf-users@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 15, 2023 at 05:30:55PM -0700, Sean Christopherson wrote: > Hide vfio_file_set_kvm() and its unique helpers if KVM is not enabled, > nothing else in the kernel (or out of the kernel) should be using a > KVM specific helper. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio_main.c | 2 +- > include/linux/vfio.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) Patch subject should be vfio not virt Reviewed-by: Jason Gunthorpe > @@ -1388,6 +1387,7 @@ void vfio_file_set_kvm(struct file *file, struct kvm *kvm) > vfio_device_file_set_kvm(file, kvm); > } > EXPORT_SYMBOL_GPL(vfio_file_set_kvm); > +#endif We could even put this in a symbol namespace.. Jason