From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 909BAE810DC for ; Wed, 27 Sep 2023 12:47:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OCKu0Q83; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Rwbwq0gdLz3cHN for ; Wed, 27 Sep 2023 22:47:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OCKu0Q83; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=mani@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Rwbvr4cLsz2yDM for ; Wed, 27 Sep 2023 22:46:32 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 35594CE1A26; Wed, 27 Sep 2023 12:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B9FAC433C8; Wed, 27 Sep 2023 12:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695818788; bh=yur1lIib+MwlO3G13u5slhNv5izV70kTNuXNh85akv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OCKu0Q83mtA+/cOefVFb4tQpEBvyJOqtu9iQ6NQiatNAdI4ptP52X2BoZwD6ToknT H1LzC/biabj/L2oKT3gPEC3fNlrLY5sCnYelvnyItmu3MW+e9tHaD/iIvGM9jq74Su cjhozkVVEkuCbqNcZsmRdwjCou8lxdFd1/dyvo481oLo+kF+Y9XMsMgIAZ4CuomM+U dEcsdT2z2qQArfP7MJbs0bpQgg9vp3FSpPsG5jcME63VN4IlM1FUTUbhAP5lTa/mVt KMIB960gL8I2Nm9GxoR9CXm7FevWBgwfuCRk1k5Uc0gRrWGsNOA+xURidh1tUE7GAx gEnrE4Mah85AA== Date: Wed, 27 Sep 2023 14:46:21 +0200 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask Message-ID: <20230927124621.GD18050@thinkpad> References: <20230926140445.3855365-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230926140445.3855365-1-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kw@linux.com, imx@lists.linux.dev, linux-pci@vger.kernel.org, lpieralisi@kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, minghuan.Lian@nxp.com, christophe.jaillet@wanadoo.fr, mingkai.hu@nxp.com, roy.zang@nxp.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote: > From: Guanhua Gao > > Set DMA mask and coherent DMA mask to enable 64-bit addressing. > > Signed-off-by: Guanhua Gao > Signed-off-by: Hou Zhiqiang > Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam - Mani > --- > > Notes: > change from v2 to v3 > - remove check return value of dma_set_mask_and_coherent. 64bit mask always > return success. > - remove redundate comments > change from v1 to v2 > - Remove 32bit DMA mask set. > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index de4c1758a6c3..2c2c9aaa8700 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian"); > > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > + > platform_set_drvdata(pdev, pcie); > > ret = dw_pcie_ep_init(&pci->ep); > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்