From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB179E732D1 for ; Thu, 28 Sep 2023 13:37:56 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fQY4RQBX; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RxF0g3G0Yz3cBL for ; Thu, 28 Sep 2023 23:37:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fQY4RQBX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RxDzh3mwJz3bx0 for ; Thu, 28 Sep 2023 23:37:03 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AF3DFCE21CE; Thu, 28 Sep 2023 13:37:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30ED8C433C8; Thu, 28 Sep 2023 13:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695908220; bh=+wQRUm2msRT1Vv6LzHjx16q1r07oTZukLX6w4Q72cRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fQY4RQBXMdvdqFGAIafv/Phk7Y1oE+EJjzKjC3TRuINAbWxqzcqLPwyX0a9VAn7db lrLv0OwYBTVD2TtgiIEZJRfo0bKqoMi2GBhCLXf4v+k2xekgAHOfI6frhHYfLI3c4k s478XPbm0PhMMeW0NqTPzj3Xl+SvTPCIBgs7SdE0= Date: Thu, 28 Sep 2023 15:36:55 +0200 From: Greg Kroah-Hartman To: j.granados@samsung.com Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Message-ID: <2023092855-cultivate-earthy-4d25@gregkh> References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , Steve Wahl , Joonas Lahtinen , Clemens Ladisch , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, Phillip Potter , Song Liu , Eric Dumazet , "K. Y. Srinivasan" , Jiri Slaby , Russ Weight , Wei Liu , Stefano Stabellini , Corey Minyard , Leon Romanovsky , linux-rdma@vger.kernel.org, David Airlie , "Rafael J. Wysocki" , Dexuan Cui , willy@infradead.org, Jason Gunthorpe , linux-serial@vger.kernel.org, Doug Gilbert , Jakub Kicinski , Paolo Abeni , Haiyang Zhang , Kees Cook , Arnd Bergmann , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , intel-gfx@lists.freedesktop.org, josh@joshtriplett.org, Jani Nikula , linux-raid@vger.kernel.org, Rodrigo Vivi , xen-devel@lists.xenproject.org, openipmi-developer@lists.sourceforge.net, Juergen Gross , Tvrtko Ursulin , Theodore Ts'o , linux-scsi@vger.kernel.org, "Martin K. Petersen" , netdev@vger.kernel.org, David Ahern , Robin Holt , Sudip Mukherjee , Oleksandr Tyshchenko , Luis Chamberlain , Daniel Vetter , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel element from cdrom_table > > Signed-off-by: Joel Granados > --- > drivers/cdrom/cdrom.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index cc2839805983..451907ade389 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > .maxlen = sizeof(int), > .mode = 0644, > .proc_handler = cdrom_sysctl_handler > - }, > - { } > + } You should have the final entry as "}," so as to make any future additions to the list to only contain that entry, that's long been the kernel style for lists like this. So your patches will just remove one line, not 2 and add 1, making it a smaller diff. thanks, greg k-h