From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA7B9E9371D for ; Mon, 9 Oct 2023 22:51:11 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uXLBAcbt; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S4Dly2WwQz3vnm for ; Tue, 10 Oct 2023 09:51:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uXLBAcbt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S43sf3lvdz3c4V; Tue, 10 Oct 2023 03:10:30 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8AAB4CE149F; Mon, 9 Oct 2023 16:10:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A92FFC433C8; Mon, 9 Oct 2023 16:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696867824; bh=keW4wOj90e6SAzWHDhiijPY7xlKn91ViUXq7+ZBy/qA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uXLBAcbtT3qSJRhL/8M371BpeA1C5ljwEOv35PPhR9AAXbskswQIJClC2lj7Rj5gp Wf8DMgzdk7F1Im4JpcUlzudlx2J7u7qAkCKVl53l50QCMlVywy97j4Z/z6YC81cPOB ZEhm/bd89ThwJczgLVLfYGYQSRgf/gJFEhHLWwuJMYiWS6kKeieI6gsrdpEaduSXjN MyDpNqeyNgkjuA9pNpJc3RCwGGB/UZ94Td6pVCF9naF2MzsC97YBscCdHyiZxAMM7J TNVG7+Kfo/TbzJEmvAHe6SdjHTFA0oLVhgfu0YPY0D5YqFYWH70KP0wz8Tk3JvnzVy Fp4FzyfzRg4Qw== From: Christian Brauner To: Jeff Layton Subject: Re: [PATCH v2 00/89] fs: new accessor methods for inode atime and mtime Date: Mon, 9 Oct 2023 18:09:31 +0200 Message-Id: <20231009-charmant-locken-893b11849e84@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231004185221.80802-1-jlayton@kernel.org> References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=10941; i=brauner@kernel.org; h=from:subject:message-id; bh=IjD9jhCYjdIJ9vPkYDocQbsMoCTgovwgHUWkZ/3GCzk=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSqqLYye23auu+81JbW5Y9by59u2veoRtMoSybRa4ps7qMV 1SnPO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTAG4yFyPDct4beVfC7N9kTeGsyQvesc LrVB9X8d5HrqtS30c2lc/vYPgrs2DPvYLs+5rO5WFr0n0CStp+xH9eLnqRR9iW68ZB+QY+AA== X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 10 Oct 2023 09:46:11 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Konstantin Komarov , "Rafael J. Wysocki" , "Darrick J. Wong" , Anders Larsen , Carlos Llamas , Andrii Nakryiko , Mattia Dongili , Hugh Dickins , John Johansen , Yonghong Song , Alexander Gordeev , Christoph Hellwig , Mike Marshall , Paulo Alcantara , linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, James Morris , Christoph Hellwig , Christian Borntraeger , devel@lists.orangefs.org, Shyam Prasad N , linux-um@lists.infradead.org, Nicholas Piggin , Alexander Viro , Eric Van Hensbergen , Suren Baghdasaryan , Trond Myklebust , Anton Altaparmakov , Christian Brauner , Greg Kroah-Hartman , Stephen Smalley , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ronnie Sahlberg , Sergey Senozhatsky , arve@android.com, Chuck Lever , Sven Schnelle , Jiri Olsa , Jan Kara , Tejun Heo , Andrew Morton , linux-trace-kernel@vger.kernel.org, Linus Torvalds , Dave Kleikamp , linux-mm@kvack.org, Joel Fernandes , Eric Dumazet , Stanislav Fomichev , linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, Paul Moore , Leon Romanovsky , John Fastabend , Luis Chamberlain , codalist@coda.cs.cmu.edu, Iurii Zaikin , Namjae Jeon , Masami Hiramatsu , Todd Kjos , Vasily Gorbik , selinux@vger.kernel.org, Brian Foster , linuxppc-dev@lists.ozlabs.org, reiserfs-devel@vger.kernel.org, Miklos Szeredi , Yue Hu , Jaegeuk Kim , Martijn Coenen , OGAWA Hirofumi , Hao Luo , Tony Luck , Theodore Ts'o , Nicolas Pitre , linux-ntfs-dev@lists.sourceforge.net, Muchun Song , linux-f2fs-devel@lists.sourceforge.net, "Guilherme G. Piccoli" , gfs2@lists.linux.dev, Eric Biederman , Anna Schumaker , Brad Warrum , Mike Kravetz , linux-efi@vger.kernel.org, Martin Brandenburg , ocfs2-devel@lists.linux.dev, Alexei Starovoitov , platform-driver-x86@vger.kernel.org, Chris Mason , linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org, Marc Dionne , Jiri Slaby , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Daniel Borkmann , Dennis Dalessandro , linux-rdma@vger.kernel.org, coda@cs.cmu.edu, ilpo.jarvinen@linux.intel.com, Ilya Dryomov , Paolo Abeni , "Serge E. Hallyn" , Christian Schoenebeck , Kees Cook , Arnd Bergmann , autofs@vger.kernel.org, Steven Rostedt , Mark Gross , Damien Le Moal , Eric Paris , ceph-devel@vger.kernel.org, Gao Xiang , Jan Harkes , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, Olga Kornievskaia , Song Liu , samba-technical@lists.samba.org, Steve French , Jeremy Kerr , netdev@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, linux-erofs@lists.ozlabs.org, "David S. Miller" , Chandan Babu R , jfs-discussion@lists.sourceforge.net, Jan Kara , Neil Brown , Dominique Martinet , Amir Goldstein , Bob Copeland , KP Singh , linux-unionfs@vger.kernel.org, David Howells , Joseph Qi , Andreas Dilger , Mikulas Patocka , Ard Biesheuvel , Anton Ivanov , Andreas Gruenbacher , Richard Weinberger , Mark Fasheh , Dai Ngo , Jason Gunthorpe , linux-serial@vger.kernel.org, Jakub Kicinski , Salah Triki , Evgeniy Dushistov , linux-cifs@vger.kernel.org, Heiko Carstens , Chao Yu , apparmor@lists.ubuntu.com, Josef Bacik , Tom Talpey , Hans de Goede , "Tigran A. Aivazian" , David Sterba , Xiubo Li , Ryusuke Konishi , Johannes Thumshirn , Ritu Agarwal , Luis de Bethencourt , Martin KaFai Lau , v9fs@lists.linux.dev, Kent Overstreet , David Sterba , linux-security-module@vger.kernel.org, Jeffle Xu , Phillip Lougher , Johannes Berg , Sungjong Seo , David Woodhouse , linux-karma-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, Joel Becker Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 04, 2023 at 02:52:21PM -0400, Jeff Layton wrote: > v2: > - bugfix in mtime handling > - incorporate _sec and _nsec accessor functions (Chuck Lever) > - move i_generation to plug hole after changing timestamps (Amir Goldstein) > > While working on the multigrain timestamp changes, Linus suggested > adding some similar wrappers for accessing the atime and mtime that we > have for the ctime. With that, we could then move to using discrete > integers instead of struct timespec64 in struct inode and shrink it. > > This patch implements this. Linus suggested using macros for the new > accessors, but the existing ctime wrappers were static inlines and since > there are only 3 different timestamps, I didn't see that trying to > fiddle with macros would gain us anything (other than less verbosity in > fs.h). > > [...] This was applied on top of -next but vfs.ctime is now based on v6.6-rc3 as stable tag otherwise this is too much of a moving target with other stuff in -next. Anything that had to be dropped and requires fixups should just be explained in the pr. The sooner this sees some -next, the better, I think. --- Applied to the vfs.ctime branch of the vfs/vfs.git tree. Patches in the vfs.ctime branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.ctime [01/86] fs: new accessor methods for atime and mtime https://git.kernel.org/vfs/vfs/c/22f45fee808d [02/86] fs: convert core infrastructure to new timestamp accessors https://git.kernel.org/vfs/vfs/c/6ac95fb71485 [03/86] spufs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/9953073d5f20 [04/86] hypfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/1d64bfe22112 [05/86] android: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a8a74b6b4f2c [06/86] char: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/671ffa0775a7 [07/86] qib: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/ebd5458f3b52 [08/86] ibmasm: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/1d4257d57a41 [09/86] misc: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/d4bf8378b9cb [10/86] x86: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/070601b1e496 [11/86] tty: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/5c9f26b87bed [12/86] function: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/092f46404245 [13/86] legacy: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/5c51d80e51d0 [14/86] usb: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/4707a33afd6f [15/86] 9p: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/20fc454b4493 [16/86] adfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/3e8d59046f6d [17/86] affs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/60d4d0d37086 [18/86] afs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/6471772aa6fe [19/86] autofs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/3eaad981548b [20/86] befs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/21d0433caf69 [21/86] bfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/06e502c123a6 [22/86] btrfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/f62049d7838d [23/86] ceph: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/ac7750d84e38 [24/86] coda: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/5c4bf2507baa [25/86] configfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/3b930e187f16 [26/86] cramfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/bb0bf9d3bda8 [27/86] debugfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/7dc950e659d6 [28/86] devpts: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a1eb5c26d5a1 [29/86] efivarfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/17b5652aa824 [30/86] efs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a3cfbea29e7d [31/86] erofs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/2beccde96d66 [32/86] exfat: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/522f3c42c9e7 [33/86] ext2: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/07be81fce412 [34/86] ext4: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/2ff285d78c4d [35/86] f2fs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/c495130561ae [36/86] fat: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/e57260ae3226 [37/86] freevxfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a83513cd029e [38/86] fuse: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/5f1e57582b4e [39/86] gfs2: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a5f1a9296668 [40/86] hfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/7ee8d53576e9 [41/86] hfsplus: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/2179ad3569f6 [42/86] hostfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/c3e1be490207 [43/86] hpfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/e08a2ea26b41 [44/86] hugetlbfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a9701db0ca64 [45/86] isofs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/362d327da07e [46/86] jffs2: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/36a8a5a63218 [47/86] jfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/acd529413de5 [48/86] kernfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/05acde68936b [49/86] minix: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/34c1ca111ec1 [50/86] nfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/77e808456854 [51/86] nfsd: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/a800ed7ebbbf [52/86] nilfs2: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/4ddc9518c2fa [53/86] ntfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/0d15c2118b1a [54/86] ntfs3: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/82f8d5fde753 [55/86] ocfs2: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/45251ebaca70 [56/86] omfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/e7c1ff814326 [57/86] openpromfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/cb62db1d3c61 [58/86] orangefs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/68e257a49aed [59/86] overlayfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/d482d98dc1bd [60/86] proc: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/8c8afe8a25fa [61/86] pstore: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/b0be548328a2 [62/86] qnx4: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/c28589f2d838 [63/86] qnx6: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/ae0f3d29e728 [64/86] ramfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/6315fd97a8fc [65/86] reiserfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/8eceb9b75a5b [66/86] romfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/6d3dd456da31 [67/86] client: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/b14d4c14f51b [68/86] server: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/bec3d7ffcecd [69/86] squashfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/d7d5ff75af52 [70/86] sysv: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/39f012d8743e [71/86] tracefs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/22ada3856de8 [72/86] ubifs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/af8b66e1d4b7 [73/86] udf: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/1da45142f95a [74/86] ufs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/41c46d3bb9b3 [75/86] vboxsf: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/cc36ec7935eb [76/86] xfs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/ee3be90b2ba7 [77/86] zonefs: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/8c798cc16b17 [78/86] linux: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/dd53b64b6f51 [79/86] ipc: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/f132b3723b71 [80/86] bpf: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/448a018f67a3 [81/86] mm: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/b6f5b3d5ffc9 [82/86] sunrpc: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/fc9db028b8d7 [83/86] apparmor: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/794ef2a745ec [84/86] selinux: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/3d57ee3686d7 [85/86] security: convert to new timestamp accessors https://git.kernel.org/vfs/vfs/c/71f6d9ebaf43 [86/86] fs: rename inode i_atime and i_mtime fields https://git.kernel.org/vfs/vfs/c/fea0e8fc7829