From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CABC1E95A8E for ; Mon, 9 Oct 2023 14:27:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ptdUM/7c; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S41Zy3QVsz3dFL for ; Tue, 10 Oct 2023 01:27:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ptdUM/7c; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.195; helo=relay3-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S41Yy4FDJz2yts for ; Tue, 10 Oct 2023 01:26:44 +1100 (AEDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2E7FF60003; Mon, 9 Oct 2023 14:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696861598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92a8cVu3f6Pk3ndmVwnkeBH7DnuU13PZsLWlEFgkb+8=; b=ptdUM/7cMSJVYbBrfF6v7pOBngBBoqD2a0R/MUuEMeanPcoDEjfHKfSoM8A8bH79+drPz+ rV97RU0p5QyeWtYFPXNPPjzGoSwoAmb7zdtM9zta8Rt3qazcKpntePvK1epyDuMN8Yy2hm c/19/YApYNnYXqqPcSlzxHZDNltzGOFF0avCXI1W6tyEQLx7YzapC/yKZuEgCSulDYhE2G tiyCi8WMCoTIVnh6t72FOyCiEhCyW0D3+DoI+D5rSdROAfpCBAIJTfQNC5r7tEla35zU7C xa3pdnMAu7WiFZoTgbzZKx+vu0/qFQeygmLxg4z1lzB3Rw48ksl43ELSnmswNA== Date: Mon, 9 Oct 2023 16:26:32 +0200 From: Herve Codina To: Jakub Kicinski Subject: Re: [PATCH v7 10/30] net: wan: Add support for QMC HDLC Message-ID: <20231009162632.7f11a6d9@bootlin.com> In-Reply-To: <20231006144702.778c165e@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-11-herve.codina@bootlin.com> <20231006144702.778c165e@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Christophe JAILLET , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , Simon Horman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Jakub, On Fri, 6 Oct 2023 14:47:02 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:28 +0200 Herve Codina wrote: > > +static int qmc_hdlc_close(struct net_device *netdev) > > +{ > > + struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev); > > + struct qmc_hdlc_desc *desc; > > + int i; > > + > > + netif_stop_queue(netdev); > > + > > + qmc_chan_stop(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > + qmc_chan_reset(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > stopping the queue looks a bit racy, a completion may come in > and restart the queue Indeed, qmc_hdlc_xmit_complete() completion can restart the queue. I will call netif_stop_queue() after calling qmc_chan_stop/reset(). This is the simple way to fix that without adding an internal flag. Thanks for pointing that. Best regards, Hervé > > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->tx_descs); i++) { > > + desc = &qmc_hdlc->tx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_TO_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->rx_descs); i++) { > > + desc = &qmc_hdlc->rx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_FROM_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + hdlc_close(netdev);