From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
irogers@google.com, namhyung@kernel.org
Cc: atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell
Date: Fri, 13 Oct 2023 13:00:18 +0530 [thread overview]
Message-ID: <20231013073021.99794-1-atrajeev@linux.vnet.ibm.com> (raw)
shellcheck was run on perf tool shell scripts as a pre-requisite
to include a build option for shellcheck discussed here:
https://www.spinics.net/lists/linux-perf-users/msg25553.html
And fixes were added for the coding/formatting issues in
two patchsets:
https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atrajeev@linux.vnet.ibm.com/
https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atrajeev@linux.vnet.ibm.com/
Three additional issues were observed and fixes are part of:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
With recent commits in perf, other three issues are observed.
shellcheck version: 0.6.0
The changes are with recent commits ( which is mentioned in each patch)
for lock_contention, record_sideband and stat_all_metricgroups test.
Patch series fixes these testcases and patches are on top of:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
The version 1 patchset had fix patch for test_arm_coresight.sh.
Dropping that in V2 based on discussion here:
https://lore.kernel.org/linux-perf-users/F265857D-0D37-4878-908C-D20732F212F9@linux.vnet.ibm.com/T/#u
Athira Rajeev (3):
tools/perf/tests Ignore the shellcheck SC2046 warning in
lock_contention
tools/perf/tests: Fix shellcheck warning in record_sideband.sh test
tools/perf/tests/shell: Fix shellcheck warning SC2112 with
stat_all_metricgroups
tools/perf/tests/shell/lock_contention.sh | 1 +
tools/perf/tests/shell/record_sideband.sh | 2 +-
tools/perf/tests/shell/stat_all_metricgroups.sh | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
--
2.31.1
next reply other threads:[~2023-10-13 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 7:30 Athira Rajeev [this message]
2023-10-13 7:30 ` [PATCH V2 1/3] tools/perf/tests Ignore the shellcheck SC2046 warning in lock_contention Athira Rajeev
2023-10-13 7:30 ` [PATCH V2 2/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test Athira Rajeev
2023-10-13 7:30 ` [PATCH V2 3/3] tools/perf/tests/shell: Fix shellcheck warning SC2112 with stat_all_metricgroups Athira Rajeev
2023-10-17 2:04 ` [PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell Namhyung Kim
2023-10-17 19:55 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013073021.99794-1-atrajeev@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).