From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yi Yang <yiyang13@huawei.com>
Cc: robh@kernel.org, vigneshr@ti.com, richard@nod.at,
tudor.ambarus@linaro.org, linux-mtd@lists.infradead.org,
npiggin@gmail.com, u.kleine-koenig@pengutronix.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf()
Date: Thu, 19 Oct 2023 08:25:56 +0200 [thread overview]
Message-ID: <20231019082556.5053b900@xps-13> (raw)
In-Reply-To: <20231019013050.316022-1-yiyang13@huawei.com>
Hi Yi,
yiyang13@huawei.com wrote on Thu, 19 Oct 2023 01:30:50 +0000:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful by
> checking the pointer validity.
>
> Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name")
> Signed-off-by: Yi Yang <yiyang13@huawei.com>
Please re-read my previous answer and address all comments.
Thanks,
Miquèl
prev parent reply other threads:[~2023-10-19 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 1:30 [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf() Yi Yang
2023-10-19 6:25 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019082556.5053b900@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=yiyang13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).