* [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf()
@ 2023-10-19 1:30 Yi Yang
2023-10-19 6:25 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Yi Yang @ 2023-10-19 1:30 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr, mpe, npiggin, christophe.leroy,
u.kleine-koenig, tudor.ambarus, robh
Cc: linuxppc-dev, linux-mtd
devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful by
checking the pointer validity.
Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name")
Signed-off-by: Yi Yang <yiyang13@huawei.com>
---
drivers/mtd/devices/powernv_flash.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
index 66044f4f5bad..956a79c739e5 100644
--- a/drivers/mtd/devices/powernv_flash.c
+++ b/drivers/mtd/devices/powernv_flash.c
@@ -207,6 +207,10 @@ static int powernv_flash_set_driver_info(struct device *dev,
* get them
*/
mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFP", dev->of_node);
+ if (!mtd->name) {
+ dev_err(dev, "failed to allocate mtd->name\n");
+ return -ENOMEM;
+ }
mtd->type = MTD_NORFLASH;
mtd->flags = MTD_WRITEABLE;
mtd->size = size;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf()
2023-10-19 1:30 [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf() Yi Yang
@ 2023-10-19 6:25 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2023-10-19 6:25 UTC (permalink / raw)
To: Yi Yang
Cc: robh, vigneshr, richard, tudor.ambarus, linux-mtd, npiggin,
u.kleine-koenig, linuxppc-dev
Hi Yi,
yiyang13@huawei.com wrote on Thu, 19 Oct 2023 01:30:50 +0000:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful by
> checking the pointer validity.
>
> Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name")
> Signed-off-by: Yi Yang <yiyang13@huawei.com>
Please re-read my previous answer and address all comments.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-19 6:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-19 1:30 [PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf() Yi Yang
2023-10-19 6:25 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).