From: Greg KH <gregkh@linuxfoundation.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
Witold Baryluk <witold.baryluk@gmail.com>,
pavel@ucw.cz, gregory.greenman@intel.com, stf_xl@wp.pl,
linux-staging@lists.linux.dev, ilw@linux.intel.com,
geert@linux-m68k.org, kuba@kernel.org, stas.yakovlev@gmail.com,
arnd@arndb.de, nicolas.ferre@microchip.com,
linux-arm-kernel@lists.infradead.org, arnd@kernel.org,
geoff@infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-wireless@vger.kernel.org, claudiu.beznea@tuxon.dev,
johannes@sipsolutions.net, quic_jjohnson@quicinc.com,
davem@davemloft.net, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers
Date: Fri, 27 Oct 2023 09:07:36 +0200 [thread overview]
Message-ID: <2023102709-purse-repressed-d8b9@gregkh> (raw)
In-Reply-To: <87o7gld8l4.fsf@kernel.org>
On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote:
> For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0',
> removing those is a good a start. Also converting the ugly debug_level
> procfs file to something more modern would be nice, maybe using just
> dev_dbg() throught the driver is a good option? Or maybe use a module
> parameter instead?
Ick, no new module parameters, this isn't the 1990's, please just use
the netdev debug lines instead :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-27 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 22:27 [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Witold Baryluk
2023-10-25 22:48 ` Philipp Hortmann
2023-10-26 9:49 ` Kalle Valo
2023-10-26 9:51 ` Johannes Berg
2023-10-26 9:41 ` Kalle Valo
2023-10-27 7:07 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-23 13:19 [PATCH 00/10] Remove obsolete and orphaned wifi drivers Arnd Bergmann
2023-10-23 13:19 ` [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Arnd Bergmann
2023-10-23 14:39 ` Kalle Valo
2023-10-23 23:43 ` Stefan Lippers-Hollmann
2023-10-24 9:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102709-purse-repressed-d8b9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=gregory.greenman@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=pavel@ucw.cz \
--cc=quic_jjohnson@quicinc.com \
--cc=stas.yakovlev@gmail.com \
--cc=stf_xl@wp.pl \
--cc=witold.baryluk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).