From: Bjorn Helgaas <helgaas@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: linux-pci@vger.kernel.org,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b
Date: Tue, 31 Oct 2023 09:56:00 -0500 [thread overview]
Message-ID: <20231031145600.GA9161@bhelgaas> (raw)
In-Reply-To: <202310282050.Y5D8ZPCw-lkp@intel.com>
[+cc powerpc, clang folks]
On Sat, Oct 28, 2023 at 08:22:54PM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/xilinx-xdma
> branch HEAD: 8d786149d78c7784144c7179e25134b6530b714b PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
>
> Error/Warning ids grouped by kconfigs:
>
> clang_recent_errors
> `-- powerpc-pmac32_defconfig
> |-- arch-powerpc-sysdev-grackle.c:error:unused-function-grackle_set_stg-Werror-Wunused-function
> |-- arch-powerpc-xmon-xmon.c:error:unused-function-get_output_lock-Werror-Wunused-function
> `-- arch-powerpc-xmon-xmon.c:error:unused-function-release_output_lock-Werror-Wunused-function
This report is close to useless. It doesn't show the complete error
message, it doesn't show how to reproduce the issue, and the pci -next
branch (including controller/xilinx-xdma) doesn't reference any of
these functions:
$ git grep -E "grackle_set_stg|get_output_lock|release_output_lock" | cat
arch/powerpc/sysdev/grackle.c:static inline void grackle_set_stg(struct pci_controller* bp, int enable)
arch/powerpc/sysdev/grackle.c: grackle_set_stg(hose, 1);
arch/powerpc/xmon/xmon.c:static void get_output_lock(void)
arch/powerpc/xmon/xmon.c:static void release_output_lock(void)
arch/powerpc/xmon/xmon.c:static inline void get_output_lock(void) {}
arch/powerpc/xmon/xmon.c:static inline void release_output_lock(void) {}
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
arch/powerpc/xmon/xmon.c: get_output_lock();
arch/powerpc/xmon/xmon.c: release_output_lock();
That said, the unused functions do look legit:
grackle_set_stg() is a static function and the only call is under
"#if 0".
Same with get_output_lock() and release_output_lock(): they're static
and always defined in xmon.c, but only called if either CONFIG_SMP or
CONFIG_DEBUG_FS.
But they're certainly not related to controller/xilinx-xdma, so I'm
going to ignore them.
Bjorn
P.S. Nathan & Nick, I cc'd you because of this earlier report that
also mentioned grackle_set_stg():
https://lore.kernel.org/lkml/202308121120.u2d3YPVt-lkp@intel.com/
next parent reply other threads:[~2023-10-31 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202310282050.Y5D8ZPCw-lkp@intel.com>
2023-10-31 14:56 ` Bjorn Helgaas [this message]
2023-10-31 16:24 ` [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b Segher Boessenkool
2023-10-31 16:59 ` Nick Desaulniers
2023-10-31 17:14 ` Bjorn Helgaas
2023-11-01 9:25 ` Arnd Bergmann
2023-11-01 17:34 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031145600.GA9161@bhelgaas \
--to=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).