From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FCE5C4167B for ; Sat, 11 Nov 2023 00:56:00 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=FzBEDdGG; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SRy1B38ZXz3cXJ for ; Sat, 11 Nov 2023 11:55:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=FzBEDdGG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.198.163.7; helo=mgamail.intel.com; envelope-from=lkp@intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SRy0B5frVz2yDM for ; Sat, 11 Nov 2023 11:55:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699664107; x=1731200107; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KgItv/ApTMzbbLUCfMBBLavSFstnBCJW3M6AwXJNXEs=; b=FzBEDdGGZPEJMHZFoHQ1WOaFoZxnRUvYMsMootwNX0NREWakHD9aH1qO Wh2PvNbgsPjfdCvq8maBSRBwBXQmQJdImGoEcvbbtjR4H/iEYNPcZMEQQ t44khiU9XcVDbE6ib8h/7hDQOawtv/VA80e7M+joLWHuSRK3i0dvQpDhB hwM2Sn1cw0RGAYMZjvFtRA4PayydeDDE7qMNxx/UaeMuMRJmEcD63rO/l T90g5Oes7ReO/QfLS6MvjXklu+T/teY8Y+QyJlTR/j7xffS+EraotmkUf earCXhDBEZbLoNH9MRizdDvTY/x+cQYV00lcesXN2sgQhOid3Oy8DRmZI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="11798488" X-IronPort-AV: E=Sophos;i="6.03,293,1694761200"; d="scan'208";a="11798488" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 16:54:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="767442282" X-IronPort-AV: E=Sophos;i="6.03,293,1694761200"; d="scan'208";a="767442282" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 10 Nov 2023 16:54:53 -0800 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1r1cGx-000A69-1x; Sat, 11 Nov 2023 00:54:51 +0000 Date: Sat, 11 Nov 2023 08:54:10 +0800 From: kernel test robot To: Shengjiu Wang , hverkuil@xs4all.nl, sakari.ailus@iki.fi, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v9 15/15] media: vim2m-audio: add virtual driver for audio memory to memory Message-ID: <202311110805.xhszmZN7-lkp@intel.com> References: <1699595289-25773-16-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1699595289-25773-16-git-send-email-shengjiu.wang@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Shengjiu, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on broonie-sound/for-next tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.6 next-20231110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shengjiu-Wang/ASoC-fsl_asrc-define-functions-for-memory-to-memory-usage/20231110-143635 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/1699595289-25773-16-git-send-email-shengjiu.wang%40nxp.com patch subject: [PATCH v9 15/15] media: vim2m-audio: add virtual driver for audio memory to memory config: powerpc64-allyesconfig (https://download.01.org/0day-ci/archive/20231111/202311110805.xhszmZN7-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231111/202311110805.xhszmZN7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311110805.xhszmZN7-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/media/test-drivers/vim2m-audio.c:174:13: warning: variable 'dst_size' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] 174 | } else if (q_data_src->rate * 2 == q_data_dst->rate) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/test-drivers/vim2m-audio.c:184:46: note: uninitialized use occurs here 184 | vb2_set_plane_payload(&dst_buf->vb2_buf, 0, dst_size); | ^~~~~~~~ drivers/media/test-drivers/vim2m-audio.c:174:9: note: remove the 'if' if its condition is always true 174 | } else if (q_data_src->rate * 2 == q_data_dst->rate) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/test-drivers/vim2m-audio.c:137:24: note: initialize the variable 'dst_size' to silence this warning 137 | int src_size, dst_size; | ^ | = 0 1 warning generated. vim +174 drivers/media/test-drivers/vim2m-audio.c 123 124 /* 125 * mem2mem callbacks 126 */ 127 128 /* 129 * device_run() - prepares and starts the device 130 */ 131 static void device_run(void *priv) 132 { 133 struct audm2m_ctx *ctx = priv; 134 struct audm2m_dev *audm2m_dev; 135 struct vb2_v4l2_buffer *src_buf, *dst_buf; 136 struct audm2m_q_data *q_data_src, *q_data_dst; 137 int src_size, dst_size; 138 short *src_addr, *dst_addr; 139 int i; 140 141 audm2m_dev = ctx->dev; 142 143 q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_AUDIO_OUTPUT); 144 if (!q_data_src) 145 return; 146 147 q_data_dst = get_q_data(ctx, V4L2_BUF_TYPE_AUDIO_CAPTURE); 148 if (!q_data_dst) 149 return; 150 151 src_buf = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); 152 dst_buf = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); 153 src_buf->sequence = q_data_src->sequence++; 154 dst_buf->sequence = q_data_dst->sequence++; 155 v4l2_m2m_buf_copy_metadata(src_buf, dst_buf, false); 156 157 /* Process the conversion */ 158 src_size = vb2_get_plane_payload(&src_buf->vb2_buf, 0); 159 160 src_addr = vb2_plane_vaddr(&src_buf->vb2_buf, 0); 161 dst_addr = vb2_plane_vaddr(&dst_buf->vb2_buf, 0); 162 163 if (q_data_src->rate == q_data_dst->rate) { 164 memcpy(dst_addr, src_addr, src_size); 165 dst_size = src_size; 166 } else if (q_data_src->rate == 2 * q_data_dst->rate) { 167 /* 8k to 16k */ 168 for (i = 0; i < src_size / 2; i++) { 169 *dst_addr++ = *src_addr++; 170 src_addr++; 171 } 172 173 dst_size = src_size / 2; > 174 } else if (q_data_src->rate * 2 == q_data_dst->rate) { 175 /* 16k to 8k */ 176 for (i = 0; i < src_size / 2; i++) { 177 *dst_addr++ = *src_addr; 178 *dst_addr++ = *src_addr++; 179 } 180 181 dst_size = src_size * 2; 182 } 183 184 vb2_set_plane_payload(&dst_buf->vb2_buf, 0, dst_size); 185 186 src_buf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx); 187 dst_buf = v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx); 188 189 v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); 190 v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); 191 v4l2_m2m_job_finish(audm2m_dev->m2m_dev, ctx->fh.m2m_ctx); 192 } 193 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki