From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A236C54FB9 for ; Thu, 16 Nov 2023 16:10:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SWQ3q6CQhz3d8W for ; Fri, 17 Nov 2023 03:10:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.161.53; helo=mail-oo1-f53.google.com; envelope-from=robherring2@gmail.com; receiver=lists.ozlabs.org) Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SWQ3B64NJz307y for ; Fri, 17 Nov 2023 03:09:41 +1100 (AEDT) Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-58a7d13b00bso540117eaf.1 for ; Thu, 16 Nov 2023 08:09:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700150978; x=1700755778; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aOcig5yxgC/BK7paxQilGIUUqt33158KEtjyWWD9YNQ=; b=mKasOQgrqsd9x5d6LinLEeVrlK5VV/Fj8W8Z3D3Rg5zHmJJW2hg1uBO7xpQReqWrcT XBc2vC9nf9fhplvHlxe5Xf1623BL5piNgraJE9qp/nM2xe1Cuo1aj8Aqhgr4XSex1DcD pREpE0f0vN3qgVX41CuhB8voB+urWMzeb22Qtsp2U1UmEoNA3uc10P//okq9FDy5fIlz L1RfJBJT+ND++at15R94POErV+mxLlhjEo4gpI9rC8FXxA1KgR4Q9VoELg225JFWTPXK WUiz/WOWHHX7T0KFEp6dh4Yc19WRss3FMhhRlNbj5VErYWsLs8TELadqcx6FGUmrU+dA WQIw== X-Gm-Message-State: AOJu0YwD5U5CyppcCS8xPV2Lt7C6x6oYhRBuV2TIusyA0LUrQIGUBcss u1lHO5zCGArehfgfYmYMEqiedAOXuA== X-Google-Smtp-Source: AGHT+IF+0KlzPHTSAYd8f0qoIp2VoeCx7YS9oDEEvzGxQfpBkJopgD5yuI9JsZg7rhEeaLCizK3xpA== X-Received: by 2002:a4a:9248:0:b0:57d:e76d:c206 with SMTP id g8-20020a4a9248000000b0057de76dc206mr16692489ooh.1.1700150978164; Thu, 16 Nov 2023 08:09:38 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d8-20020a4aaa88000000b0058a133c3641sm611522oon.6.2023.11.16.08.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 08:09:37 -0800 (PST) Received: (nullmailer pid 2416819 invoked by uid 1000); Thu, 16 Nov 2023 16:09:36 -0000 Date: Thu, 16 Nov 2023 10:09:36 -0600 From: Rob Herring To: Daniel Walker Subject: Re: [PATCH 7/8] of: replace command line handling Message-ID: <20231116160936.GA2376455-robh@kernel.org> References: <20231110013817.2378507-1-danielwa@cisco.com> <20231110013817.2378507-8-danielwa@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110013817.2378507-8-danielwa@cisco.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tomas Mudrunka , Daniel Gimpelevich , Frank Rowand , Sean Anderson , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, Pratyush Brahma , linux-mips@vger.kernel.org, xe-linux-external@cisco.com, Andrew Morton , Will Deacon , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 09, 2023 at 05:38:11PM -0800, Daniel Walker wrote: > Rob Herring has complained about this section of code. I removed the > command line handling code to the cmdline.h header. This hopefully makes > it easier for Rob to maintain it (at least he doesn't have to look at it > directly anymore). Well, my goal is to eliminate drivers/of/, but no. > I would like to add a Kconfig option called > OF_DEPRECATED_CMDLINE which an architecture would set if it uses this code. Which architecture needs this code? Do we wait and see who complains their platform broke and then go set this option? In the meantime, new platforms started depending on the new behavior and setting the option may break them. So we can't have a kconfig option. > This would allow a platform to use the cmdline.h and the added function > directly and remove the Kconfig option. This change would be in a subsequent > patch. Per platform code handling the cmdline is completely the wrong direction. Per arch behavior is bad enough. Rob