From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAAD4C2BB3F for ; Sat, 18 Nov 2023 11:36:19 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=scYJ4WjY; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SXWtn71hHz3dL0 for ; Sat, 18 Nov 2023 22:36:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=scYJ4WjY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SXWsp2nKkz3c8c for ; Sat, 18 Nov 2023 22:35:25 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4463BCE0304; Sat, 18 Nov 2023 11:35:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D285EC433C8; Sat, 18 Nov 2023 11:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700307318; bh=OgG2e3JDQ+aMaFQKaQHhqxbxwXDPAGQ1d6SyxmbzQdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=scYJ4WjYaxXhSxGGMBk8baExUYwt1smeRQtnrHSE1PQUGYddkffPEMQViJ6Em65dW PVnfVVo0a7IvuOeICohX8JQS0877utTtVEnz5sq9xpDwPzddIvc/FlazUBMIDHWTuu LcW2yEPshGCBN/aR66RHgN4PNpeDTCR/vh1drtrg= Date: Sat, 18 Nov 2023 06:35:14 -0500 From: Greg KH To: Matthew Maurer Subject: Re: [PATCH v2 1/5] export_report: Rehabilitate script Message-ID: <2023111809-mayday-citable-4fbd@gregkh> References: <20231118025748.2778044-1-mmaurer@google.com> <20231118025748.2778044-2-mmaurer@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231118025748.2778044-2-mmaurer@google.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Schier , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, Masahiro Yamada , Nick Desaulniers , linux-kernel@vger.kernel.org, Nathan Chancellor , Luis Chamberlain , Gary Guo , Miguel Ojeda , Laura Abbott , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Nov 18, 2023 at 02:54:42AM +0000, Matthew Maurer wrote: > * modules.order has .o files when in a build dir, support this > * .mod.c source layout has changed, update regexes to match > * Add a stage 3, to be more robust against additional .mod.c content When you have to list different things you do in a patch, that is a huge hint that you need to break up your patch into smaller pieces. Remember, each patch can only do one logical thing. I know it feels odd, but it makes it easier to review. This patch, as-is, is nothing that I would be able to take, please make it a series. thanks, greg k-h