From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Naveen N Rao <naveen@kernel.org>
Subject: Re: [PATCH] powerpc/Makefile: Remove bits related to the previous use of -mcmodel=large
Date: Tue, 9 Jan 2024 12:39:36 -0600 [thread overview]
Message-ID: <20240109183936.GK19790@gate.crashing.org> (raw)
In-Reply-To: <47691590-3698-4dea-b093-6619796fa9ea@csgroup.eu>
On Tue, Jan 09, 2024 at 03:15:35PM +0000, Christophe Leroy wrote:
> > CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mcall-aixdesc)
> > endif
> > endif
> > -CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mcmodel=medium,$(call cc-option,-mminimal-toc))
> > +CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mcmodel=medium)
>
> Should we still use $(call cc-option here ?
> As we only deal with medium model now, shouldn't we make it such that it
> fails in case the compiler doesn't support -mcmodel=medium ?
The -mcmodel= flag has been supported since 2010. The kernel requires
a GCC from 2015 or later (GCC 5.1 is the minimum). -mcmodel=medium is
(and always has been) the default, so it is always supported, yes.
Segher
next prev parent reply other threads:[~2024-01-09 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:34 [PATCH] powerpc/Makefile: Remove bits related to the previous use of -mcmodel=large Naveen N Rao
2024-01-09 15:15 ` Christophe Leroy
2024-01-09 18:39 ` Segher Boessenkool [this message]
2024-01-10 13:49 ` Naveen N Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109183936.GK19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox