From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, linux-xfs@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: peterz@infradead.org, sshegde@linux.ibm.com, mingo@kernel.org,
anton@tuxera.com, chandan.babu@oracle.com
Subject: [RFC PATCH 2/3] fs: remove duplicate ifdefs
Date: Thu, 18 Jan 2024 13:33:25 +0530 [thread overview]
Message-ID: <20240118080326.13137-3-sshegde@linux.ibm.com> (raw)
In-Reply-To: <20240118080326.13137-1-sshegde@linux.ibm.com>
when a ifdef is used in the below manner, second one could be considered as
duplicate.
ifdef DEFINE_A
...code block...
ifdef DEFINE_A
...code block...
endif
...code block...
endif
There are few places in fs code where above pattern was seen.
No functional change is intended here. It only aims to improve code
readability.
Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
fs/ntfs/inode.c | 2 --
fs/xfs/xfs_sysfs.c | 4 ----
2 files changed, 6 deletions(-)
diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c
index aba1e22db4e9..d2c8622d53d1 100644
--- a/fs/ntfs/inode.c
+++ b/fs/ntfs/inode.c
@@ -2859,11 +2859,9 @@ int ntfs_truncate(struct inode *vi)
*
* See ntfs_truncate() description above for details.
*/
-#ifdef NTFS_RW
void ntfs_truncate_vfs(struct inode *vi) {
ntfs_truncate(vi);
}
-#endif
/**
* ntfs_setattr - called from notify_change() when an attribute is being changed
diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index 17485666b672..d2391eec37fe 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -193,7 +193,6 @@ always_cow_show(
}
XFS_SYSFS_ATTR_RW(always_cow);
-#ifdef DEBUG
/*
* Override how many threads the parallel work queue is allowed to create.
* This has to be a debug-only global (instead of an errortag) because one of
@@ -260,7 +259,6 @@ larp_show(
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.larp);
}
XFS_SYSFS_ATTR_RW(larp);
-#endif /* DEBUG */
STATIC ssize_t
bload_leaf_slack_store(
@@ -319,10 +317,8 @@ static struct attribute *xfs_dbg_attrs[] = {
ATTR_LIST(log_recovery_delay),
ATTR_LIST(mount_delay),
ATTR_LIST(always_cow),
-#ifdef DEBUG
ATTR_LIST(pwork_threads),
ATTR_LIST(larp),
-#endif
ATTR_LIST(bload_leaf_slack),
ATTR_LIST(bload_node_slack),
NULL,
--
2.39.3
next prev parent reply other threads:[~2024-01-18 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:03 [RFC PATCH 0/3] remove duplicate ifdefs Shrikanth Hegde
2024-01-18 8:03 ` [RFC PATCH 1/3] sched: " Shrikanth Hegde
2024-01-18 8:03 ` Shrikanth Hegde [this message]
2024-01-19 1:35 ` [RFC PATCH 2/3] fs: " Darrick J. Wong
2024-01-22 12:50 ` Chandan Babu R
2024-01-22 14:37 ` Shrikanth Hegde
2024-01-18 8:03 ` [RFC PATCH 3/3] arch/powerpc: " Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118080326.13137-3-sshegde@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=anton@tuxera.com \
--cc=chandan.babu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).