From: Greg KH <gregkh@linuxfoundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: sashal@kernel.org, llvm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 4.19] powerpc: Use always instead of always-y in for crtsavres.o
Date: Fri, 26 Jan 2024 16:52:47 -0800 [thread overview]
Message-ID: <2024012640-macaroni-earlobe-bec5@gregkh> (raw)
In-Reply-To: <20240126-4-19-fix-lib-powerpc-backport-v1-1-f0de224db66b@kernel.org>
On Fri, Jan 26, 2024 at 10:36:31AM -0700, Nathan Chancellor wrote:
> This commit is for linux-4.19.y only, it has no direct upstream
> equivalent.
>
> Prior to commit 5f2fb52fac15 ("kbuild: rename hostprogs-y/always to
> hostprogs/always-y"), always-y did not exist, making the backport of
> mainline commit 1b1e38002648 ("powerpc: add crtsavres.o to always-y
> instead of extra-y") to linux-4.19.y as commit b7b85ec5ec15 ("powerpc:
> add crtsavres.o to always-y instead of extra-y") incorrect, breaking the
> build with linkers that need crtsavres.o:
>
> ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory
>
> Backporting the aforementioned kbuild commit is not suitable for stable
> due to its size and number of conflicts, so transform the always-y usage
> to an equivalent form using always, which resolves the build issues.
>
> Fixes: b7b85ec5ec15 ("powerpc: add crtsavres.o to always-y instead of extra-y")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
Both now queued up, thanks!
greg k-h
next prev parent reply other threads:[~2024-01-27 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:36 [PATCH 4.19] powerpc: Use always instead of always-y in for crtsavres.o Nathan Chancellor
2024-01-27 0:52 ` Greg KH [this message]
2024-01-27 0:56 ` Patch "powerpc: Use always instead of always-y in for crtsavres.o" has been added to the 4.19-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024012640-macaroni-earlobe-bec5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).