From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54118C4829C for ; Mon, 12 Feb 2024 17:03:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TYW4t6zrZz3fCg for ; Tue, 13 Feb 2024 04:03:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4TYW4L0hhhz3c9N for ; Tue, 13 Feb 2024 04:03:13 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 41CH27uB011033; Mon, 12 Feb 2024 11:02:07 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 41CH27nK011032; Mon, 12 Feb 2024 11:02:07 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 12 Feb 2024 11:02:07 -0600 From: Segher Boessenkool To: Timothy Pearson Subject: Re: [PATCH] powerpc: Add gpr1 and fpu save/restore functions Message-ID: <20240212170207.GW19790@gate.crashing.org> References: <995988479.14839534.1707756078600.JavaMail.zimbra@raptorengineeringinc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <995988479.14839534.1707756078600.JavaMail.zimbra@raptorengineeringinc.com> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Feb 12, 2024 at 10:41:18AM -0600, Timothy Pearson wrote: > Implement gpr1 and fpu save/restore functions per the ABI v2 documentation. There is no "ABI v2". This is the ELFv2 ABI, it is a name, it is not a version 2 of anything (in fact, it is version 1 everywhere). The same functions are needed and used in other ABIs, too. But, why do this patch? You just need +LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name) +libs-y += $(LIBGCC) and nothing more. It is required for proper functioning of GCC to link with the libgcc support library. Segher