From: Bitao Hu <yaoma@linux.alibaba.com>
To: dianders@chromium.org, tglx@linutronix.de,
liusong@linux.alibaba.com, akpm@linux-foundation.org,
pmladek@suse.com, kernelfans@gmail.com, deller@gmx.de,
npiggin@gmail.com, tsbogend@alpha.franken.de,
James.Bottomley@HansenPartnership.com, jan.kiszka@siemens.com
Cc: yaoma@linux.alibaba.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: [PATCHv10 3/4] genirq: Avoid summation loops for /proc/interrupts
Date: Mon, 26 Feb 2024 10:09:38 +0800 [thread overview]
Message-ID: <20240226020939.45264-4-yaoma@linux.alibaba.com> (raw)
In-Reply-To: <20240226020939.45264-1-yaoma@linux.alibaba.com>
We could use the irq_desc::tot_count member to avoid the summation
loop for interrupts which are not marked as 'PER_CPU' interrupts in
'show_interrupts'. This could reduce the time overhead of reading
/proc/interrupts.
Originally-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Bitao Hu <yaoma@linux.alibaba.com>
---
include/linux/irqdesc.h | 2 ++
kernel/irq/irqdesc.c | 2 +-
kernel/irq/proc.c | 9 +++++++--
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
index 2912b1998670..1ee96d7232b4 100644
--- a/include/linux/irqdesc.h
+++ b/include/linux/irqdesc.h
@@ -121,6 +121,8 @@ static inline void irq_unlock_sparse(void) { }
extern struct irq_desc irq_desc[NR_IRQS];
#endif
+extern bool irq_is_nmi(struct irq_desc *desc);
+
static inline unsigned int irq_desc_kstat_cpu(struct irq_desc *desc,
unsigned int cpu)
{
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 9cd17080b2d8..56a767957a9d 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -955,7 +955,7 @@ unsigned int kstat_irqs_cpu(unsigned int irq, int cpu)
return desc && desc->kstat_irqs ? per_cpu(desc->kstat_irqs->cnt, cpu) : 0;
}
-static bool irq_is_nmi(struct irq_desc *desc)
+bool irq_is_nmi(struct irq_desc *desc)
{
return desc->istate & IRQS_NMI;
}
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 6954e0a02047..b3b1b93f0410 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -489,8 +489,13 @@ int show_interrupts(struct seq_file *p, void *v)
goto outsparse;
if (desc->kstat_irqs) {
- for_each_online_cpu(j)
- any_count |= data_race(per_cpu(desc->kstat_irqs->cnt, j));
+ if (!irq_settings_is_per_cpu_devid(desc) &&
+ !irq_settings_is_per_cpu(desc) &&
+ !irq_is_nmi(desc))
+ any_count = data_race(desc->tot_count);
+ else
+ for_each_online_cpu(j)
+ any_count |= data_race(per_cpu(desc->kstat_irqs->cnt, j));
}
if ((!desc->action || irq_desc_is_chained(desc)) && !any_count)
--
2.37.1 (Apple Git-137.1)
next prev parent reply other threads:[~2024-02-26 2:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 2:09 [PATCHv10 0/4] *** Detect interrupt storm in softlockup *** Bitao Hu
2024-02-26 2:09 ` [PATCHv10 1/4] watchdog/softlockup: low-overhead detection of interrupt storm Bitao Hu
2024-02-26 2:09 ` [PATCHv10 2/4] genirq: Provide a snapshot mechanism for interrupt statistics Bitao Hu
2024-02-27 4:10 ` Liu Song
2024-02-26 2:09 ` Bitao Hu [this message]
2024-02-27 7:48 ` [PATCHv10 3/4] genirq: Avoid summation loops for /proc/interrupts Liu Song
2024-02-27 9:26 ` Thomas Gleixner
2024-02-27 11:20 ` Bitao Hu
2024-02-27 15:39 ` Thomas Gleixner
2024-02-28 6:07 ` Bitao Hu
2024-02-26 2:09 ` [PATCHv10 4/4] watchdog/softlockup: report the most frequent interrupts Bitao Hu
2024-02-27 9:02 ` Liu Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226020939.45264-4-yaoma@linux.alibaba.com \
--to=yaoma@linux.alibaba.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liusong@linux.alibaba.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).