From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B7E2C54798 for ; Tue, 27 Feb 2024 12:33:31 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zD5kCXkn; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TkcNB1z3mz3vZ3 for ; Tue, 27 Feb 2024 23:33:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zD5kCXkn; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::42f; helo=mail-pf1-x42f.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TkcMM2s16z3cQj for ; Tue, 27 Feb 2024 23:32:47 +1100 (AEDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6e4ca46ab04so2497996b3a.3 for ; Tue, 27 Feb 2024 04:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709037165; x=1709641965; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=r6McJiuv+h7AyXeU5mDp5gY4ceOSplSmKT9ljaBZAeI=; b=zD5kCXknWqO+ujdzIa7kV1i73RfiiPV9GKvJzIWOqQOcefGdVs1QOTDrJktTGmGIZy effRgB58DRwsa6gJyY1sZdQo9aNCSGr+GOyhjFvp63qH19RoD7WAaPF9BRIhIXg38kbQ jU4uiwx7AMv4aHEQgr5ou4NZJxAHAESkIoXLScLnlqTHN4OfRsyU5dQXCTQd2Nw+2c0r uoxakCCrlfKw4ku4L/h7IPJu/x4AG+MFGZIarK4qI6UdH0H23yqzUB0o49XCH3g7PAhW 5JPDjkRA9RjWAqW5O3mA9rYTG4dRXUC3ONOMtPWlPuiUgE1lTegCK7GV/DjLYrCjXAx/ 7Y0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709037165; x=1709641965; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r6McJiuv+h7AyXeU5mDp5gY4ceOSplSmKT9ljaBZAeI=; b=QrWtHyafqY0Zg8IgBFIjuJAObblGTTOvm3zCNQ7BHJn2GcqiTBXqu+0MFnE1cNKRiU HpRTRMiwu9U+hwwOn34fg61w/lMqLds7+i2VFBTrUEJBZ8x/81j7uDF+Vs/FQUogl4Ir /Pb83dDYfu1IwyNHfZpr6EucVVgU0JVJmdTCVPWmUQQrI64ll0jk3Z+jX0unosneCiiN NFp9XMQ0SFm2/XzHaR9ZNTGMBspXGqYeNJL+0nRSjsIplth0p+B0wMrOthcr0/r26/K7 z/7CUdoI1Y98y+fmLVy5bjgy8RYQO+8UsmmX6zYmqZv89aHLw3BTmVhMGgbypm4qzrRn sYZA== X-Forwarded-Encrypted: i=1; AJvYcCW2MVM9sXoHpfRpacc6kfYyvyfpw6YFiAImbGyHIs9xA3uTJtrZhl/Vd8i62+6ZL7nVBPN2d+yl+upeq9WancMudq34rMikaGCJlGgpag== X-Gm-Message-State: AOJu0YxWTTuhvClNA3myGnh4JJ3X3vAGAO5FW8/ICCsLFiz2USKD+lmn bLRZxTQyz8fg95/9ipzMe9LhExE7pig3CsP9RWv8FeaYTRJpH7UqMHGB8lFWmA== X-Google-Smtp-Source: AGHT+IEFhhrIt7Yi0/j6C6WifjMm92/qMQnfNrHB04A6+0UV4a2UVc5t/CmWxX+vY2RC+MyJMs/Upg== X-Received: by 2002:a05:6a21:910c:b0:1a0:cce6:d526 with SMTP id tn12-20020a056a21910c00b001a0cce6d526mr2594508pzb.41.1709037164773; Tue, 27 Feb 2024 04:32:44 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id fn11-20020a056a002fcb00b006e0737f2bafsm5775175pfb.45.2024.02.27.04.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 04:32:44 -0800 (PST) Date: Tue, 27 Feb 2024 18:02:30 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event Message-ID: <20240227123230.GP2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Niklas Cassel , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Feb 26, 2024 at 12:20:41PM -0500, Frank Li wrote: > On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > > Now that the API is available, let's make use of it. It also handles the > > reinitialization of DWC non-sticky registers in addition to sending the > > notification to EPF drivers. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > index 2fb8c15e7a91..4e45bc4bca45 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > > if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) { > > dev_dbg(dev, "Received Linkdown event\n"); > > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > > - pci_epc_linkdown(pci->ep.epc); > > + dw_pcie_ep_linkdown(&pci->ep); > > Suppose pci_epc_linkdown() will call dw_pcie_ep_linkdown() ? > why need direct call dw_pcie_ep_linkdown() here? > I've already justified this in the commit message. Here is the excerpt: "It also handles the reinitialization of DWC non-sticky registers in addition to sending the notification to EPF drivers." - Mani -- மணிவண்ணன் சதாசிவம்