From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: venkat88@linux.vnet.ibm.com,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
"mputtash@linux.vnet.com" <mputtash@linux.vnet.com>,
Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
arkadiusz.kubalewski@intel.com,
"sachinp@linux.vnet.com" <sachinp@linux.vnet.com>,
"abdhalee@linux.vnet.ibm.com" <abdhalee@linux.vnet.ibm.com>,
jiri@nvidia.com,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure
Date: Thu, 29 Feb 2024 06:47:42 -0800 [thread overview]
Message-ID: <20240229064742.36c2f476@kernel.org> (raw)
In-Reply-To: <CANn89iKdaMFCKnGRL4ffnbyrr2PUaKn1hoiu4VZ=sRyX=Vy0Wg@mail.gmail.com>
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
> I do not see other solution than this, otherwise we have to add more
> pollution to include/linux/netdevice.h
Right :(
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a9c973b92294bb110cf3cd336485972127b01b58..40797ea80bc6273cae6b7773d0a3e47459a72150
> 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2469,7 +2469,7 @@ struct net_device {
> struct devlink_port *devlink_port;
>
> #if IS_ENABLED(CONFIG_DPLL)
> - struct dpll_pin __rcu *dpll_pin;
> + void __rcu *dpll_pin;
> #endif
If DPLL wants to hide its type definitions the helpers must live
in dpll? IOW move netdev_dpll_pin() to drivers/dpll/dpll_core.c
BTW Tasmiya, please do tell us what compiler you're using.
next prev parent reply other threads:[~2024-02-29 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 11:09 [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Tasmiya Nalatwad
2024-02-28 11:22 ` [revert 0d60d8df6f49] [netdev/net] " Tasmiya Nalatwad
2024-02-28 14:07 ` [revert 0d60d8df6f49] [net/net-next] " Vadim Fedorenko
2024-02-28 14:43 ` Eric Dumazet
2024-02-28 15:44 ` Christophe Leroy
2024-02-29 8:04 ` Tasmiya Nalatwad
2024-02-29 8:55 ` Eric Dumazet
2024-02-29 11:31 ` Tasmiya Nalatwad
2024-02-29 11:44 ` Vadim Fedorenko
2024-02-29 14:47 ` Jakub Kicinski [this message]
2024-02-29 14:53 ` Eric Dumazet
2024-02-29 15:02 ` Eric Dumazet
2024-03-01 5:06 ` Tasmiya Nalatwad
2024-03-04 11:33 ` Tasmiya Nalatwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229064742.36c2f476@kernel.org \
--to=kuba@kernel.org \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mputtash@linux.vnet.com \
--cc=sachinp@linux.vnet.com \
--cc=tasmiya@linux.vnet.ibm.com \
--cc=vadim.fedorenko@linux.dev \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).