From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 944B4C48BF6 for ; Thu, 29 Feb 2024 14:48:33 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fd8bWomS; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TlvH419xMz3vcH for ; Fri, 1 Mar 2024 01:48:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fd8bWomS; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TlvGD5Lnwz3dWk for ; Fri, 1 Mar 2024 01:47:48 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3127260C80; Thu, 29 Feb 2024 14:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C91BC43390; Thu, 29 Feb 2024 14:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709218063; bh=c7GmbVJf43ArHWG9m+LgTeyF8QmqxKm6DE7najW6vkw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fd8bWomSDlRNZkU9IB07feEamaa19n8kfPgUJONxZEAcmwiJIjF9ianrPSh2PUQ2+ NQOJxKk8u6voltML5yygA3M0NCgqDtOjxDmGmqtquTBDRHh66gOOOyIC1JThtsl6Ui Z22/moAG2DQUoobCnXVA1JIYppGFI1eu86YJTtx9/j43KU+80OhaM0eDYlu72OPp0N gXicsCxEPUx0xW+xxKkjldIor83o1qhPBJTdeCerzQkG7Ka/I5NvebRky5wr1Krvlp +AY+VMQJOL5jaSejJsGunF6zMZc+2RzWh2YPdu2w4rjTBm3O48z4WQw6x9yhL1hPI8 XLt3LA5uibv0Q== Date: Thu, 29 Feb 2024 06:47:42 -0800 From: Jakub Kicinski To: Eric Dumazet Subject: Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Message-ID: <20240229064742.36c2f476@kernel.org> In-Reply-To: References: <3fcf3a2c-1c1b-42c1-bacb-78fdcd700389@linux.vnet.ibm.com> <85b78dad-affa-47c3-9cd0-79a4321460b8@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: venkat88@linux.vnet.ibm.com, Vadim Fedorenko , "mputtash@linux.vnet.com" , Tasmiya Nalatwad , "linux-kernel@vger.kernel.org" , arkadiusz.kubalewski@intel.com, "sachinp@linux.vnet.com" , "abdhalee@linux.vnet.ibm.com" , jiri@nvidia.com, "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > I do not see other solution than this, otherwise we have to add more > pollution to include/linux/netdevice.h Right :( > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index a9c973b92294bb110cf3cd336485972127b01b58..40797ea80bc6273cae6b7773d0a3e47459a72150 > 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -2469,7 +2469,7 @@ struct net_device { > struct devlink_port *devlink_port; > > #if IS_ENABLED(CONFIG_DPLL) > - struct dpll_pin __rcu *dpll_pin; > + void __rcu *dpll_pin; > #endif If DPLL wants to hide its type definitions the helpers must live in dpll? IOW move netdev_dpll_pin() to drivers/dpll/dpll_core.c BTW Tasmiya, please do tell us what compiler you're using.