From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35230C54E64 for ; Sat, 23 Mar 2024 01:06:36 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EcMiWiUk; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V1gy25zWRz3vp9 for ; Sat, 23 Mar 2024 12:06:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EcMiWiUk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=sj@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V1gxD2YZbz3vgN for ; Sat, 23 Mar 2024 12:05:52 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7A37ECE18C7; Sat, 23 Mar 2024 01:05:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04826C433F1; Sat, 23 Mar 2024 01:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711155945; bh=3+zZh3XFJnxQpCAGDeyGmKq33BNtz2+66eAEGL4876Q=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=EcMiWiUkiXF0pmTkhVhDvP+BA3m6SBMpMePHLS3lgvhzbCdo9T5o6x2xTa8QoCvtQ ZiIr3laXn2TxW1OUddMIfS1+bJqiPdQdS/W9Rj6yvZxknL1k5q/DKyC9sWIyvTCsmL qjz9g+3k55UpMTkbn5Fmp2EPQC/vmOSHUkLHq5nPc1YFOdstql4q7f52P4kaf6kZOe OK6Xw3iZcQy36q6zjiD/Nq4FMHprCktSrO9wXGQN1nYHgDgHW9odHpf0M4qlTAphIv Qt9VjffONOVJFRHRVRK9EkkPxU/upViU53CWHBYVwXM057H2FC5cyRrlr1LY92qHmO G5ofpS5wd8PeQ== From: SeongJae Park To: Peter Xu Subject: Re: [PATCH v3 03/12] mm: Make HPAGE_PXD_* macros even if !THP Date: Fri, 22 Mar 2024 18:05:28 -0700 Message-Id: <20240323010528.10959-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, Andrea Arcangeli , "Aneesh Kumar K . V" , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , Vlastimil Babka , SeongJae Park , Lorenzo Stoakes , Muchun Song , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Peter, On Fri, 22 Mar 2024 20:30:24 -0400 Peter Xu wrote: > On Fri, Mar 22, 2024 at 10:14:56AM -0700, SeongJae Park wrote: > > Hi Peter, > > Hi, SeongJae, > > > > > On Thu, 21 Mar 2024 18:07:53 -0400 peterx@redhat.com wrote: > > > > > From: Peter Xu > > > > > > These macros can be helpful when we plan to merge hugetlb code into generic > > > code. Move them out and define them even if !THP. > > > > > > We actually already defined HPAGE_PMD_NR for other reasons even if !THP. > > > Reorganize these macros. > > > > > > Reviewed-by: Christoph Hellwig > > > Reviewed-by: Jason Gunthorpe > > > Signed-off-by: Peter Xu > > > --- > > > include/linux/huge_mm.h | 17 ++++++----------- > > > 1 file changed, 6 insertions(+), 11 deletions(-) > > > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > > index de0c89105076..3bcdfc7e5d57 100644 > > > --- a/include/linux/huge_mm.h > > > +++ b/include/linux/huge_mm.h > > > @@ -64,9 +64,6 @@ ssize_t single_hugepage_flag_show(struct kobject *kobj, > > > enum transparent_hugepage_flag flag); > > > extern struct kobj_attribute shmem_enabled_attr; > > > > > > -#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > > > -#define HPAGE_PMD_NR (1< > > - > > > /* > > > * Mask of all large folio orders supported for anonymous THP; all orders up to > > > * and including PMD_ORDER, except order-0 (which is not "huge") and order-1 > > > @@ -87,14 +84,19 @@ extern struct kobj_attribute shmem_enabled_attr; > > > #define thp_vma_allowable_order(vma, vm_flags, smaps, in_pf, enforce_sysfs, order) \ > > > (!!thp_vma_allowable_orders(vma, vm_flags, smaps, in_pf, enforce_sysfs, BIT(order))) > > > > > > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > > #define HPAGE_PMD_SHIFT PMD_SHIFT > > > #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) > > > #define HPAGE_PMD_MASK (~(HPAGE_PMD_SIZE - 1)) > > > +#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > > > +#define HPAGE_PMD_NR (1< > > > > > #define HPAGE_PUD_SHIFT PUD_SHIFT > > > #define HPAGE_PUD_SIZE ((1UL) << HPAGE_PUD_SHIFT) > > > #define HPAGE_PUD_MASK (~(HPAGE_PUD_SIZE - 1)) > > > +#define HPAGE_PUD_ORDER (HPAGE_PUD_SHIFT-PAGE_SHIFT) > > > +#define HPAGE_PUD_NR (1< > > > I just found latest mm-unstable fails one of my build configurations[1] with > > below error. 'git bisect' says this is the first patch set started the > > failure. I haven't looked in deep, but just reporting first. > > > > In file included from .../include/linux/mm.h:1115, > > from .../mm/vmstat.c:14: > > .../mm/vmstat.c: In function 'zoneinfo_show_print': > > .../include/linux/huge_mm.h:87:25: error: 'PMD_SHIFT' undeclared (first use in this function); did you mean 'PUD_SHIFT'? > > 87 | #define HPAGE_PMD_SHIFT PMD_SHIFT > > | ^~~~~~~~~ > > > > [1] https://github.com/awslabs/damon-tests/blob/next/corr/tests/build_m68k.sh > > Apologies for the issue. No problem at all, this blocks nothing in real :) > This is caused by !CONFIG_MMU, I think. > > I thought this would be fairly easy to fix by putting these macros under > CONFIG_PGTABLE_HAS_HUGE_LEAVES, however when doing this I could have found > some other issue that violates this rule.. mm/vmstat.c has referenced > HPAGE_PMD_NR even if vmstat_item_print_in_thp() wanted to guard it only > with CONFIG_THP. > > /home/peterx/git/linux/mm/vmstat.c: In function 'zoneinfo_show_print': > /home/peterx/git/linux/mm/vmstat.c:1689:42: error: 'HPAGE_PMD_NR' undeclared (first use in this function) > 1689 | pages /= HPAGE_PMD_NR; > | ^~~~~~~~~~~~ > /home/peterx/git/linux/mm/vmstat.c:1689:42: note: each undeclared identifier is reported only once for each function it appears in > CC drivers/tty/tty_port.o > /home/peterx/git/linux/mm/vmstat.c: In function 'vmstat_start': > /home/peterx/git/linux/mm/vmstat.c:1822:33: error: 'HPAGE_PMD_NR' undeclared (first use in this function) > 1822 | v[i] /= HPAGE_PMD_NR; > | ^~~~~~~~~~~~ > make[4]: *** [/home/peterx/git/linux/scripts/Makefile.build:243: mm/vmstat.o] Error 1 > > static __always_inline bool vmstat_item_print_in_thp(enum node_stat_item item) > { > if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > return false; > ... > } > > I think the problem is vmstat_item_print_in_thp() uses IS_ENABLED() however > that won't stop compiler from looking into the "if".. so it'll still try to > find the HPAGE_PMD_NR macro. > > It means, I may need to further change vmstat_item_print_in_thp() to make > this work in the clean way.. by properly switching to a #ifdef. > > For that I'll need to post a formal patch and add people to review. I'll > keep you posted. Thank you for this kind explanation, all makes sense to me. Looking forward to the patch. > > Side note: thank you for your script, just to mention make.cross has been > moved to kbuild/, and it'll also need kbuild.sh now to work. So you may > want to fix your test script (and it worked for you because you kept the > old make.cross around), like: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/kbuild/make.cross -O ./bin/make.cross > wget https://raw.githubusercontent.com/intel/lkp-tests/master/kbuild/kbuild.sh -O ./bin/kbuild.sh And thank you so much for this nice suggestion. I'll revisit the script soon. Thanks, SJ > > Thanks, > > -- > Peter Xu