* [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c
@ 2024-04-08 5:31 Yang Li
2024-04-08 5:31 ` [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu() Yang Li
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yang Li @ 2024-04-08 5:31 UTC (permalink / raw)
To: rdunlap, arnd, mpe, npiggin, christophe.leroy, aneesh.kumar,
naveen.n.rao
Cc: Yang Li, linuxppc-dev, linux-kernel
Fix some function names in kernel-doc comments.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/powerpc/sysdev/fsl_gtm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_gtm.c b/arch/powerpc/sysdev/fsl_gtm.c
index 39186ad6b3c3..3dabc9621810 100644
--- a/arch/powerpc/sysdev/fsl_gtm.c
+++ b/arch/powerpc/sysdev/fsl_gtm.c
@@ -77,7 +77,7 @@ struct gtm {
static LIST_HEAD(gtms);
/**
- * gtm_get_timer - request GTM timer to use it with the rest of GTM API
+ * gtm_get_timer16 - request GTM timer to use it with the rest of GTM API
* Context: non-IRQ
*
* This function reserves GTM timer for later use. It returns gtm_timer
@@ -110,7 +110,7 @@ struct gtm_timer *gtm_get_timer16(void)
EXPORT_SYMBOL(gtm_get_timer16);
/**
- * gtm_get_specific_timer - request specific GTM timer
+ * gtm_get_specific_timer16 - request specific GTM timer
* @gtm: specific GTM, pass here GTM's device_node->data
* @timer: specific timer number, Timer1 is 0.
* Context: non-IRQ
@@ -260,7 +260,7 @@ int gtm_set_timer16(struct gtm_timer *tmr, unsigned long usec, bool reload)
EXPORT_SYMBOL(gtm_set_timer16);
/**
- * gtm_set_exact_utimer16 - (re)set 16 bits timer
+ * gtm_set_exact_timer16 - (re)set 16 bits timer
* @tmr: pointer to the gtm_timer structure obtained from gtm_get_timer
* @usec: timer interval in microseconds
* @reload: if set, the timer will reset upon expiry rather than
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu()
2024-04-08 5:31 [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Yang Li
@ 2024-04-08 5:31 ` Yang Li
2024-04-08 15:16 ` Randy Dunlap
2024-04-08 15:15 ` [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Randy Dunlap
2024-05-08 13:39 ` Michael Ellerman
2 siblings, 1 reply; 5+ messages in thread
From: Yang Li @ 2024-04-08 5:31 UTC (permalink / raw)
To: rdunlap, arnd, mpe, npiggin, christophe.leroy, aneesh.kumar,
naveen.n.rao
Cc: Yang Li, linuxppc-dev, linux-kernel
This commit adds kernel-doc style comments with complete parameter
descriptions for the function smp_startup_cpu().
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/powerpc/platforms/cell/smp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/cell/smp.c b/arch/powerpc/platforms/cell/smp.c
index 30394c6f8894..fee638fd8970 100644
--- a/arch/powerpc/platforms/cell/smp.c
+++ b/arch/powerpc/platforms/cell/smp.c
@@ -54,6 +54,7 @@ static cpumask_t of_spin_map;
/**
* smp_startup_cpu() - start the given cpu
+ * @lcpu: Logical CPU ID of the CPU to be started.
*
* At boot time, there is nothing to do for primary threads which were
* started from Open Firmware. For anything else, call RTAS with the
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c
2024-04-08 5:31 [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Yang Li
2024-04-08 5:31 ` [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu() Yang Li
@ 2024-04-08 15:15 ` Randy Dunlap
2024-05-08 13:39 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2024-04-08 15:15 UTC (permalink / raw)
To: Yang Li, arnd, mpe, npiggin, christophe.leroy, aneesh.kumar,
naveen.n.rao
Cc: linuxppc-dev, linux-kernel
On 4/7/24 10:31 PM, Yang Li wrote:
> Fix some function names in kernel-doc comments.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/powerpc/sysdev/fsl_gtm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/fsl_gtm.c b/arch/powerpc/sysdev/fsl_gtm.c
> index 39186ad6b3c3..3dabc9621810 100644
> --- a/arch/powerpc/sysdev/fsl_gtm.c
> +++ b/arch/powerpc/sysdev/fsl_gtm.c
> @@ -77,7 +77,7 @@ struct gtm {
> static LIST_HEAD(gtms);
>
> /**
> - * gtm_get_timer - request GTM timer to use it with the rest of GTM API
> + * gtm_get_timer16 - request GTM timer to use it with the rest of GTM API
> * Context: non-IRQ
> *
> * This function reserves GTM timer for later use. It returns gtm_timer
> @@ -110,7 +110,7 @@ struct gtm_timer *gtm_get_timer16(void)
> EXPORT_SYMBOL(gtm_get_timer16);
>
> /**
> - * gtm_get_specific_timer - request specific GTM timer
> + * gtm_get_specific_timer16 - request specific GTM timer
> * @gtm: specific GTM, pass here GTM's device_node->data
> * @timer: specific timer number, Timer1 is 0.
> * Context: non-IRQ
> @@ -260,7 +260,7 @@ int gtm_set_timer16(struct gtm_timer *tmr, unsigned long usec, bool reload)
> EXPORT_SYMBOL(gtm_set_timer16);
>
> /**
> - * gtm_set_exact_utimer16 - (re)set 16 bits timer
> + * gtm_set_exact_timer16 - (re)set 16 bits timer
> * @tmr: pointer to the gtm_timer structure obtained from gtm_get_timer
> * @usec: timer interval in microseconds
> * @reload: if set, the timer will reset upon expiry rather than
--
#Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu()
2024-04-08 5:31 ` [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu() Yang Li
@ 2024-04-08 15:16 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2024-04-08 15:16 UTC (permalink / raw)
To: Yang Li, arnd, mpe, npiggin, christophe.leroy, aneesh.kumar,
naveen.n.rao
Cc: linuxppc-dev, linux-kernel
On 4/7/24 10:31 PM, Yang Li wrote:
> This commit adds kernel-doc style comments with complete parameter
> descriptions for the function smp_startup_cpu().
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/powerpc/platforms/cell/smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/cell/smp.c b/arch/powerpc/platforms/cell/smp.c
> index 30394c6f8894..fee638fd8970 100644
> --- a/arch/powerpc/platforms/cell/smp.c
> +++ b/arch/powerpc/platforms/cell/smp.c
> @@ -54,6 +54,7 @@ static cpumask_t of_spin_map;
>
> /**
> * smp_startup_cpu() - start the given cpu
> + * @lcpu: Logical CPU ID of the CPU to be started.
> *
> * At boot time, there is nothing to do for primary threads which were
> * started from Open Firmware. For anything else, call RTAS with the
--
#Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c
2024-04-08 5:31 [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Yang Li
2024-04-08 5:31 ` [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu() Yang Li
2024-04-08 15:15 ` [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Randy Dunlap
@ 2024-05-08 13:39 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2024-05-08 13:39 UTC (permalink / raw)
To: rdunlap, arnd, mpe, npiggin, christophe.leroy, aneesh.kumar,
naveen.n.rao, Yang Li
Cc: linuxppc-dev, linux-kernel
On Mon, 08 Apr 2024 13:31:08 +0800, Yang Li wrote:
> Fix some function names in kernel-doc comments.
>
>
Applied to powerpc/next.
[2/3] powerpc: Fix kernel-doc comments in fsl_gtm.c
https://git.kernel.org/powerpc/c/97bd2693b399cfd436acaa230d8f09e4c39e8e5c
[3/3] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu()
https://git.kernel.org/powerpc/c/554da5e0f71238384787954242d881cfeeff844d
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-08 13:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-08 5:31 [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Yang Li
2024-04-08 5:31 ` [PATCH -next 3/3 v2] powerpc/rtas: Add kernel-doc comments to smp_startup_cpu() Yang Li
2024-04-08 15:16 ` Randy Dunlap
2024-04-08 15:15 ` [PATCH -next 2/3 v2] powerpc: Fix kernel-doc comments in fsl_gtm.c Randy Dunlap
2024-05-08 13:39 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).