From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: nicolas@fjasle.eu, peterz@infradead.org, masahiroy@kernel.org,
mahesh@linux.ibm.com, mingo@kernel.org, nathan@kernel.org,
sv@linux.ibm.com, npiggin@gmail.com, naveen.n.rao@linux.ibm.com,
jpoimboe@kernel.org
Subject: [RFC PATCH 1/2] objtool: Run objtool only if either of the config options are selected
Date: Mon, 22 Apr 2024 14:52:05 +0530 [thread overview]
Message-ID: <20240422092206.147078-1-sv@linux.ibm.com> (raw)
Currently, when objtool is enabled and none of the supported options
are triggered, kernel build errors out with the below error:
error: objtool: At least one command required.
To address this, ensure that objtool is run only when either of the
config options are selected.
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
scripts/Makefile.lib | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 3179747cbd2c..c65bb0fbd136 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -286,7 +286,10 @@ objtool-args = $(objtool-args-y) \
delay-objtool := $(or $(CONFIG_LTO_CLANG),$(CONFIG_X86_KERNEL_IBT))
+ifneq ($(objtool-args-y),)
cmd_objtool = $(if $(objtool-enabled), ; $(objtool) $(objtool-args) $@)
+endif
+
cmd_gen_objtooldep = $(if $(objtool-enabled), { echo ; echo '$@: $$(wildcard $(objtool))' ; } >> $(dot-target).cmd)
endif # CONFIG_OBJTOOL
--
2.34.1
next reply other threads:[~2024-04-22 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 9:22 Sathvika Vasireddy [this message]
2024-04-22 9:22 ` [RFC PATCH 2/2] objtool/powerpc: Enhance objtool to fixup alternate feature relative addresses Sathvika Vasireddy
2024-04-23 0:28 ` Nathan Chancellor
2024-06-03 8:29 ` Sathvika Vasireddy
2024-05-06 16:50 ` Masahiro Yamada
2024-04-22 12:09 ` [RFC PATCH 1/2] objtool: Run objtool only if either of the config options are selected Masahiro Yamada
2024-04-22 16:18 ` Sathvika Vasireddy
2024-05-06 17:39 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422092206.147078-1-sv@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=masahiroy@kernel.org \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=nicolas@fjasle.eu \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).