* [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
2024-05-31 0:55 ` Kuninori Morimoto
` (2 more replies)
2024-05-30 22:58 ` [PATCH v1 2/6] ASoC: fsl: " Andy Shevchenko
` (4 subsequent siblings)
5 siblings, 3 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/codecs/ak4118.c | 1 -
sound/soc/codecs/ak4458.c | 1 -
sound/soc/codecs/aw88399.c | 1 -
sound/soc/codecs/cs53l30.c | 1 -
sound/soc/codecs/max98390.c | 1 -
sound/soc/codecs/pcm3168a.c | 1 -
sound/soc/codecs/rk817_codec.c | 1 -
sound/soc/codecs/tas2552.c | 1 -
sound/soc/codecs/tas2764.c | 1 -
sound/soc/codecs/tas2770.c | 1 -
sound/soc/codecs/tas2780.c | 1 -
sound/soc/codecs/tas2781-comlib.c | 1 -
sound/soc/codecs/tas2781-fmwlib.c | 1 -
sound/soc/codecs/tas2781-i2c.c | 1 -
sound/soc/codecs/tlv320adc3xxx.c | 1 -
sound/soc/codecs/tlv320adcx140.c | 1 -
sound/soc/codecs/tlv320aic31xx.c | 1 -
sound/soc/codecs/ts3a227e.c | 1 -
sound/soc/codecs/wsa883x.c | 1 -
19 files changed, 19 deletions(-)
diff --git a/sound/soc/codecs/ak4118.c b/sound/soc/codecs/ak4118.c
index 9a43235e6a11..23e868e4e3fb 100644
--- a/sound/soc/codecs/ak4118.c
+++ b/sound/soc/codecs/ak4118.c
@@ -9,7 +9,6 @@
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index 73cf482f104f..32cb802ad635 100644
--- a/sound/soc/codecs/ak4458.c
+++ b/sound/soc/codecs/ak4458.c
@@ -10,7 +10,6 @@
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/pm_runtime.h>
#include <linux/regulator/consumer.h>
#include <linux/reset.h>
diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c
index 9fcb805bf971..23e50d73b4c4 100644
--- a/sound/soc/codecs/aw88399.c
+++ b/sound/soc/codecs/aw88399.c
@@ -10,7 +10,6 @@
#include <linux/crc32.h>
#include <linux/i2c.h>
#include <linux/firmware.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <sound/soc.h>
#include "aw88399.h"
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index c0893146423b..2ee13d885fdc 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -12,7 +12,6 @@
#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/regulator/consumer.h>
#include <sound/pcm_params.h>
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index 57fa2db1e148..1bae253618fd 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -13,7 +13,6 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <linux/slab.h>
#include <linux/time.h>
diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 9d6431338fb7..3c0e0fdbfc5c 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -11,7 +11,6 @@
#include <linux/delay.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/pm_runtime.h>
#include <linux/regulator/consumer.h>
diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index d4da98469f8b..5fea600bc3a4 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -10,7 +10,6 @@
#include <linux/mfd/rk808.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <sound/core.h>
diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index a7ed59ec49a6..9e68afc09897 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -13,7 +13,6 @@
#include <linux/device.h>
#include <linux/i2c.h>
#include <linux/gpio.h>
-#include <linux/of_gpio.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c
index 1dc719d726ab..5eaddf07aadc 100644
--- a/sound/soc/codecs/tas2764.c
+++ b/sound/soc/codecs/tas2764.c
@@ -15,7 +15,6 @@
#include <linux/regulator/consumer.h>
#include <linux/regmap.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/soc.h>
#include <sound/pcm.h>
diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
index 67bc1c8b0131..5601fba17c96 100644
--- a/sound/soc/codecs/tas2770.c
+++ b/sound/soc/codecs/tas2770.c
@@ -20,7 +20,6 @@
#include <linux/firmware.h>
#include <linux/regmap.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/soc.h>
#include <sound/pcm.h>
diff --git a/sound/soc/codecs/tas2780.c b/sound/soc/codecs/tas2780.c
index a18ccf5fb7ad..6902bfef185b 100644
--- a/sound/soc/codecs/tas2780.c
+++ b/sound/soc/codecs/tas2780.c
@@ -11,7 +11,6 @@
#include <linux/gpio/consumer.h>
#include <linux/regmap.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <sound/soc.h>
#include <sound/pcm.h>
#include <sound/pcm_params.h>
diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c
index 3aa81514dad7..2eb3b384f9e7 100644
--- a/sound/soc/codecs/tas2781-comlib.c
+++ b/sound/soc/codecs/tas2781-comlib.c
@@ -14,7 +14,6 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index 265a8ca25cbb..d6afab542da7 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -13,7 +13,6 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 9350972dfefe..c9086fe42419 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -21,7 +21,6 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/sound/soc/codecs/tlv320adc3xxx.c b/sound/soc/codecs/tlv320adc3xxx.c
index e100cc9f5c19..eb180df9a72a 100644
--- a/sound/soc/codecs/tlv320adc3xxx.c
+++ b/sound/soc/codecs/tlv320adc3xxx.c
@@ -25,7 +25,6 @@
#include <linux/i2c.h>
#include <linux/platform_device.h>
#include <linux/cdev.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/core.h>
#include <sound/pcm.h>
diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
index 41342b340680..d594bf166c0e 100644
--- a/sound/soc/codecs/tlv320adcx140.c
+++ b/sound/soc/codecs/tlv320adcx140.c
@@ -12,7 +12,6 @@
#include <linux/regulator/consumer.h>
#include <linux/acpi.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/core.h>
#include <sound/pcm.h>
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index 4d7c5a80c6ed..2f94cfda0e33 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -23,7 +23,6 @@
#include <linux/regulator/consumer.h>
#include <linux/acpi.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
#include <sound/core.h>
#include <sound/jack.h>
diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c
index dbf448dd8864..b9eb59e3bfa0 100644
--- a/sound/soc/codecs/ts3a227e.c
+++ b/sound/soc/codecs/ts3a227e.c
@@ -10,7 +10,6 @@
#include <linux/init.h>
#include <linux/input.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <linux/acpi.h>
diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
index a2e86ef7d18f..8abce2160d65 100644
--- a/sound/soc/codecs/wsa883x.c
+++ b/sound/soc/codecs/wsa883x.c
@@ -9,7 +9,6 @@
#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/pm_runtime.h>
#include <linux/printk.h>
#include <linux/regmap.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
2024-05-30 22:58 ` [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h Andy Shevchenko
@ 2024-05-31 0:55 ` Kuninori Morimoto
2024-05-31 6:42 ` kernel test robot
2024-05-31 14:58 ` Charles Keepax
2 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2024-05-31 0:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: imx, alsa-devel, Heiko Stuebner, Xiubo Li, Marco Felsch,
David Rhodes, Kevin Lu, Srinivas Kandagatla, Sylwester Nawrocki,
Shawn Guo, Alper Nebi Yasak, Rob Herring, Shengjiu Wang,
Takashi Iwai, linux-rockchip, Uwe Kleine-König, Baojun Xu,
Pengutronix Kernel Team, Sascha Hauer, Shenghao Ding,
James Schulman, Nicolin Chen, Richard Fitzgerald, Mark Brown,
linux-sound, Fabio Estevam, Jaroslav Kysela, linux-arm-kernel,
Weidong Wang, Liam Girdwood, linux-kernel, Chancel Liu,
Banajit Goswami, patches, linuxppc-dev
Hi
> of_gpio.h is deprecated and subject to remove. The drivers in question
> don't use it, simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/codecs/ak4118.c | 1 -
> sound/soc/codecs/ak4458.c | 1 -
> sound/soc/codecs/aw88399.c | 1 -
> sound/soc/codecs/cs53l30.c | 1 -
> sound/soc/codecs/max98390.c | 1 -
> sound/soc/codecs/pcm3168a.c | 1 -
> sound/soc/codecs/rk817_codec.c | 1 -
> sound/soc/codecs/tas2552.c | 1 -
> sound/soc/codecs/tas2764.c | 1 -
> sound/soc/codecs/tas2770.c | 1 -
> sound/soc/codecs/tas2780.c | 1 -
> sound/soc/codecs/tas2781-comlib.c | 1 -
> sound/soc/codecs/tas2781-fmwlib.c | 1 -
> sound/soc/codecs/tas2781-i2c.c | 1 -
> sound/soc/codecs/tlv320adc3xxx.c | 1 -
> sound/soc/codecs/tlv320adcx140.c | 1 -
> sound/soc/codecs/tlv320aic31xx.c | 1 -
> sound/soc/codecs/ts3a227e.c | 1 -
> sound/soc/codecs/wsa883x.c | 1 -
> 19 files changed, 19 deletions(-)
For pcm3168a
Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> diff --git a/sound/soc/codecs/ak4118.c b/sound/soc/codecs/ak4118.c
> index 9a43235e6a11..23e868e4e3fb 100644
> --- a/sound/soc/codecs/ak4118.c
> +++ b/sound/soc/codecs/ak4118.c
> @@ -9,7 +9,6 @@
> #include <linux/gpio/consumer.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
>
> diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
> index 73cf482f104f..32cb802ad635 100644
> --- a/sound/soc/codecs/ak4458.c
> +++ b/sound/soc/codecs/ak4458.c
> @@ -10,7 +10,6 @@
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/pm_runtime.h>
> #include <linux/regulator/consumer.h>
> #include <linux/reset.h>
> diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c
> index 9fcb805bf971..23e50d73b4c4 100644
> --- a/sound/soc/codecs/aw88399.c
> +++ b/sound/soc/codecs/aw88399.c
> @@ -10,7 +10,6 @@
> #include <linux/crc32.h>
> #include <linux/i2c.h>
> #include <linux/firmware.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <sound/soc.h>
> #include "aw88399.h"
> diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
> index c0893146423b..2ee13d885fdc 100644
> --- a/sound/soc/codecs/cs53l30.c
> +++ b/sound/soc/codecs/cs53l30.c
> @@ -12,7 +12,6 @@
> #include <linux/delay.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/regulator/consumer.h>
> #include <sound/pcm_params.h>
> diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> index 57fa2db1e148..1bae253618fd 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -13,7 +13,6 @@
> #include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> #include <linux/time.h>
> diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
> index 9d6431338fb7..3c0e0fdbfc5c 100644
> --- a/sound/soc/codecs/pcm3168a.c
> +++ b/sound/soc/codecs/pcm3168a.c
> @@ -11,7 +11,6 @@
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/pm_runtime.h>
> #include <linux/regulator/consumer.h>
>
> diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
> index d4da98469f8b..5fea600bc3a4 100644
> --- a/sound/soc/codecs/rk817_codec.c
> +++ b/sound/soc/codecs/rk817_codec.c
> @@ -10,7 +10,6 @@
> #include <linux/mfd/rk808.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <sound/core.h>
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index a7ed59ec49a6..9e68afc09897 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -13,7 +13,6 @@
> #include <linux/device.h>
> #include <linux/i2c.h>
> #include <linux/gpio.h>
> -#include <linux/of_gpio.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c
> index 1dc719d726ab..5eaddf07aadc 100644
> --- a/sound/soc/codecs/tas2764.c
> +++ b/sound/soc/codecs/tas2764.c
> @@ -15,7 +15,6 @@
> #include <linux/regulator/consumer.h>
> #include <linux/regmap.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/slab.h>
> #include <sound/soc.h>
> #include <sound/pcm.h>
> diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
> index 67bc1c8b0131..5601fba17c96 100644
> --- a/sound/soc/codecs/tas2770.c
> +++ b/sound/soc/codecs/tas2770.c
> @@ -20,7 +20,6 @@
> #include <linux/firmware.h>
> #include <linux/regmap.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/slab.h>
> #include <sound/soc.h>
> #include <sound/pcm.h>
> diff --git a/sound/soc/codecs/tas2780.c b/sound/soc/codecs/tas2780.c
> index a18ccf5fb7ad..6902bfef185b 100644
> --- a/sound/soc/codecs/tas2780.c
> +++ b/sound/soc/codecs/tas2780.c
> @@ -11,7 +11,6 @@
> #include <linux/gpio/consumer.h>
> #include <linux/regmap.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <sound/soc.h>
> #include <sound/pcm.h>
> #include <sound/pcm_params.h>
> diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c
> index 3aa81514dad7..2eb3b384f9e7 100644
> --- a/sound/soc/codecs/tas2781-comlib.c
> +++ b/sound/soc/codecs/tas2781-comlib.c
> @@ -14,7 +14,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
> index 265a8ca25cbb..d6afab542da7 100644
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -13,7 +13,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
> index 9350972dfefe..c9086fe42419 100644
> --- a/sound/soc/codecs/tas2781-i2c.c
> +++ b/sound/soc/codecs/tas2781-i2c.c
> @@ -21,7 +21,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/sound/soc/codecs/tlv320adc3xxx.c b/sound/soc/codecs/tlv320adc3xxx.c
> index e100cc9f5c19..eb180df9a72a 100644
> --- a/sound/soc/codecs/tlv320adc3xxx.c
> +++ b/sound/soc/codecs/tlv320adc3xxx.c
> @@ -25,7 +25,6 @@
> #include <linux/i2c.h>
> #include <linux/platform_device.h>
> #include <linux/cdev.h>
> -#include <linux/of_gpio.h>
> #include <linux/slab.h>
> #include <sound/core.h>
> #include <sound/pcm.h>
> diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
> index 41342b340680..d594bf166c0e 100644
> --- a/sound/soc/codecs/tlv320adcx140.c
> +++ b/sound/soc/codecs/tlv320adcx140.c
> @@ -12,7 +12,6 @@
> #include <linux/regulator/consumer.h>
> #include <linux/acpi.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/slab.h>
> #include <sound/core.h>
> #include <sound/pcm.h>
> diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
> index 4d7c5a80c6ed..2f94cfda0e33 100644
> --- a/sound/soc/codecs/tlv320aic31xx.c
> +++ b/sound/soc/codecs/tlv320aic31xx.c
> @@ -23,7 +23,6 @@
> #include <linux/regulator/consumer.h>
> #include <linux/acpi.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/slab.h>
> #include <sound/core.h>
> #include <sound/jack.h>
> diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c
> index dbf448dd8864..b9eb59e3bfa0 100644
> --- a/sound/soc/codecs/ts3a227e.c
> +++ b/sound/soc/codecs/ts3a227e.c
> @@ -10,7 +10,6 @@
> #include <linux/init.h>
> #include <linux/input.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <linux/acpi.h>
>
> diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
> index a2e86ef7d18f..8abce2160d65 100644
> --- a/sound/soc/codecs/wsa883x.c
> +++ b/sound/soc/codecs/wsa883x.c
> @@ -9,7 +9,6 @@
> #include <linux/init.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/pm_runtime.h>
> #include <linux/printk.h>
> #include <linux/regmap.h>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
2024-05-30 22:58 ` [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h Andy Shevchenko
2024-05-31 0:55 ` Kuninori Morimoto
@ 2024-05-31 6:42 ` kernel test robot
2024-05-31 14:30 ` Andy Shevchenko
2024-05-31 14:58 ` Charles Keepax
2 siblings, 1 reply; 12+ messages in thread
From: kernel test robot @ 2024-05-31 6:42 UTC (permalink / raw)
To: Andy Shevchenko, Rob Herring, Weidong Wang, Mark Brown,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Liam Girdwood, Baojun Xu, Shengjiu Wang, llvm, Takashi Iwai,
Jaroslav Kysela, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, oe-kbuild-all, Xiubo Li,
James Schulman, David Rhodes
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on shawnguo/for-next rockchip/for-next linus/master v6.10-rc1 next-20240529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ASoC-codecs-Remove-unused-of_gpio-h/20240531-070350
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20240530230037.1156253-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
config: i386-buildonly-randconfig-006-20240531 (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405311428.tzsBMIPs-lkp@intel.com/
All errors (new ones prefixed by >>):
>> sound/soc/codecs/tas2781-comlib.c:408:6: error: call to undeclared function 'gpio_is_valid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
408 | if (gpio_is_valid(tas_priv->irq_info.irq_gpio))
| ^
sound/soc/codecs/tas2781-comlib.c:408:6: note: did you mean 'uuid_is_valid'?
include/linux/uuid.h:102:19: note: 'uuid_is_valid' declared here
102 | bool __must_check uuid_is_valid(const char *uuid);
| ^
>> sound/soc/codecs/tas2781-comlib.c:409:3: error: call to undeclared function 'gpio_free'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
409 | gpio_free(tas_priv->irq_info.irq_gpio);
| ^
sound/soc/codecs/tas2781-comlib.c:409:3: note: did you mean 'pmd_free'?
include/asm-generic/pgtable-nopmd.h:63:20: note: 'pmd_free' declared here
63 | static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)
| ^
2 errors generated.
--
>> sound/soc/codecs/tas2781-i2c.c:664:6: error: call to undeclared function 'gpio_is_valid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
664 | if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) {
| ^
sound/soc/codecs/tas2781-i2c.c:664:6: note: did you mean 'uuid_is_valid'?
include/linux/uuid.h:102:19: note: 'uuid_is_valid' declared here
102 | bool __must_check uuid_is_valid(const char *uuid);
| ^
>> sound/soc/codecs/tas2781-i2c.c:665:8: error: call to undeclared function 'gpio_request'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
665 | rc = gpio_request(tas_priv->irq_info.irq_gpio,
| ^
>> sound/soc/codecs/tas2781-i2c.c:668:4: error: call to undeclared function 'gpio_direction_input'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
668 | gpio_direction_input(
| ^
sound/soc/codecs/tas2781-i2c.c:668:4: note: did you mean 'gpiod_direction_input'?
include/linux/gpio/consumer.h:110:5: note: 'gpiod_direction_input' declared here
110 | int gpiod_direction_input(struct gpio_desc *desc);
| ^
>> sound/soc/codecs/tas2781-i2c.c:672:5: error: call to undeclared function 'gpio_to_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
672 | gpio_to_irq(tas_priv->irq_info.irq_gpio);
| ^
sound/soc/codecs/tas2781-i2c.c:672:5: note: did you mean 'gpiod_to_irq'?
include/linux/gpio/consumer.h:167:5: note: 'gpiod_to_irq' declared here
167 | int gpiod_to_irq(const struct gpio_desc *desc);
| ^
4 errors generated.
vim +/gpio_is_valid +408 sound/soc/codecs/tas2781-comlib.c
ef3bcde75d06d6 Shenghao Ding 2023-06-18 405
ef3bcde75d06d6 Shenghao Ding 2023-06-18 406 void tasdevice_remove(struct tasdevice_priv *tas_priv)
ef3bcde75d06d6 Shenghao Ding 2023-06-18 407 {
ef3bcde75d06d6 Shenghao Ding 2023-06-18 @408 if (gpio_is_valid(tas_priv->irq_info.irq_gpio))
ef3bcde75d06d6 Shenghao Ding 2023-06-18 @409 gpio_free(tas_priv->irq_info.irq_gpio);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 410 mutex_destroy(&tas_priv->codec_lock);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 411 }
ef3bcde75d06d6 Shenghao Ding 2023-06-18 412 EXPORT_SYMBOL_GPL(tasdevice_remove);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 413
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
2024-05-31 6:42 ` kernel test robot
@ 2024-05-31 14:30 ` Andy Shevchenko
0 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-31 14:30 UTC (permalink / raw)
To: kernel test robot
Cc: imx, alsa-devel, Kuninori Morimoto, Xiubo Li, llvm, Marco Felsch,
linux-kernel, Kevin Lu, Srinivas Kandagatla, Shengjiu Wang,
Rob Herring, Takashi Iwai, Richard Fitzgerald, linux-rockchip,
Uwe Kleine-König, Baojun Xu, Shenghao Ding, James Schulman,
Alper Nebi Yasak, Mark Brown, linux-sound, oe-kbuild-all,
Jaroslav Kysela, linux-arm-kernel, Weidong Wang, David Rhodes,
Liam Girdwood, Chancel Liu, Banajit Goswami, patches,
linuxppc-dev
On Fri, May 31, 2024 at 02:42:33PM +0800, kernel test robot wrote:
> Hi Andy,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on broonie-sound/for-next]
> [also build test ERROR on shawnguo/for-next rockchip/for-next linus/master v6.10-rc1 next-20240529]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ASoC-codecs-Remove-unused-of_gpio-h/20240531-070350
> base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> patch link: https://lore.kernel.org/r/20240530230037.1156253-2-andriy.shevchenko%40linux.intel.com
> patch subject: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
> config: i386-buildonly-randconfig-006-20240531 (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@intel.com/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405311428.tzsBMIPs-lkp@intel.com/
My gosh, the whoever wrote the GPIO code in that driver has no clue what they
are doing. It's a pure mess.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
2024-05-30 22:58 ` [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h Andy Shevchenko
2024-05-31 0:55 ` Kuninori Morimoto
2024-05-31 6:42 ` kernel test robot
@ 2024-05-31 14:58 ` Charles Keepax
2 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2024-05-31 14:58 UTC (permalink / raw)
To: Andy Shevchenko
Cc: imx, alsa-devel, Heiko Stuebner, Kuninori Morimoto, Xiubo Li,
Marco Felsch, David Rhodes, Kevin Lu, Srinivas Kandagatla,
Sylwester Nawrocki, Shawn Guo, Shengjiu Wang, Rob Herring,
Fabio Estevam, Takashi Iwai, Richard Fitzgerald, linux-rockchip,
Uwe Kleine-König, Baojun Xu, Pengutronix Kernel Team,
Sascha Hauer, Shenghao Ding, James Schulman, Nicolin Chen,
Alper Nebi Yasak, Mark Brown, linux-sound, Jaroslav Kysela,
linux-arm-kernel, Weidong Wang, Liam Girdwood, linux-kernel,
Chancel Liu, Banajit Goswami, patches, linuxppc-dev
On Fri, May 31, 2024 at 01:58:47AM +0300, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove. The drivers in question
> don't use it, simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/soc/codecs/cs53l30.c | 1 -
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 2/6] ASoC: fsl: Remove unused of_gpio.h
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 3/6] ASoC: rockchip: " Andy Shevchenko
` (3 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/fsl/imx-es8328.c | 1 -
sound/soc/fsl/imx-rpmsg.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/sound/soc/fsl/imx-es8328.c b/sound/soc/fsl/imx-es8328.c
index 5b9648f3b087..3ef92f6dfc6b 100644
--- a/sound/soc/fsl/imx-es8328.c
+++ b/sound/soc/fsl/imx-es8328.c
@@ -8,7 +8,6 @@
#include <linux/of.h>
#include <linux/of_platform.h>
#include <linux/i2c.h>
-#include <linux/of_gpio.h>
#include <sound/soc.h>
#include <sound/jack.h>
diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
index 0f1ad7ad7d27..ce98d2288193 100644
--- a/sound/soc/fsl/imx-rpmsg.c
+++ b/sound/soc/fsl/imx-rpmsg.c
@@ -5,9 +5,7 @@
#include <linux/of_platform.h>
#include <linux/of_reserved_mem.h>
#include <linux/i2c.h>
-#include <linux/of_gpio.h>
#include <linux/slab.h>
-#include <linux/gpio.h>
#include <linux/clk.h>
#include <sound/soc.h>
#include <sound/jack.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v1 3/6] ASoC: rockchip: Remove unused of_gpio.h
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 2/6] ASoC: fsl: " Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 4/6] ASoC: codecs: Replace of_gpio.h by proper one Andy Shevchenko
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/rockchip/rockchip_i2s.c | 1 -
sound/soc/rockchip/rockchip_spdif.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index b0c3ef030e06..b378f870b3ad 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -11,7 +11,6 @@
#include <linux/mfd/syscon.h>
#include <linux/delay.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/clk.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockchip_spdif.c
index 1a24b78e9e02..eb9d5dee196e 100644
--- a/sound/soc/rockchip/rockchip_spdif.c
+++ b/sound/soc/rockchip/rockchip_spdif.c
@@ -11,7 +11,6 @@
#include <linux/module.h>
#include <linux/delay.h>
-#include <linux/of_gpio.h>
#include <linux/clk.h>
#include <linux/pm_runtime.h>
#include <linux/mfd/syscon.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v1 4/6] ASoC: codecs: Replace of_gpio.h by proper one
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
` (2 preceding siblings ...)
2024-05-30 22:58 ` [PATCH v1 3/6] ASoC: rockchip: " Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 5/6] ASoC: generic: " Andy Shevchenko
2024-05-30 22:58 ` [PATCH v1 6/6] ASoC: samsung: " Andy Shevchenko
5 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/codecs/aw88395/aw88395.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/aw88395/aw88395.c b/sound/soc/codecs/aw88395/aw88395.c
index 3c459a67ad0c..be6ebcb51cca 100644
--- a/sound/soc/codecs/aw88395/aw88395.c
+++ b/sound/soc/codecs/aw88395/aw88395.c
@@ -8,9 +8,9 @@
// Author: Weidong Wang <wangweidong.a@awinic.com>
//
+#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/firmware.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <sound/soc.h>
#include "aw88395.h"
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v1 5/6] ASoC: generic: Replace of_gpio.h by proper one
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
` (3 preceding siblings ...)
2024-05-30 22:58 ` [PATCH v1 4/6] ASoC: codecs: Replace of_gpio.h by proper one Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
2024-05-31 0:53 ` Kuninori Morimoto
2024-05-30 22:58 ` [PATCH v1 6/6] ASoC: samsung: " Andy Shevchenko
5 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/generic/audio-graph-card2-custom-sample.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/generic/audio-graph-card2-custom-sample.c b/sound/soc/generic/audio-graph-card2-custom-sample.c
index 1b6ccd2de964..8e5a51098490 100644
--- a/sound/soc/generic/audio-graph-card2-custom-sample.c
+++ b/sound/soc/generic/audio-graph-card2-custom-sample.c
@@ -5,8 +5,9 @@
// Copyright (C) 2020 Renesas Electronics Corp.
// Copyright (C) 2020 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
//
+#include <linux/device.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <sound/graph_card.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v1 5/6] ASoC: generic: Replace of_gpio.h by proper one
2024-05-30 22:58 ` [PATCH v1 5/6] ASoC: generic: " Andy Shevchenko
@ 2024-05-31 0:53 ` Kuninori Morimoto
0 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2024-05-31 0:53 UTC (permalink / raw)
To: Andy Shevchenko
Cc: imx, alsa-devel, Heiko Stuebner, Xiubo Li, Marco Felsch,
David Rhodes, Kevin Lu, Srinivas Kandagatla, Sylwester Nawrocki,
Shawn Guo, Alper Nebi Yasak, Rob Herring, Shengjiu Wang,
Takashi Iwai, linux-rockchip, Uwe Kleine-König, Baojun Xu,
Pengutronix Kernel Team, Sascha Hauer, Shenghao Ding,
James Schulman, Nicolin Chen, Richard Fitzgerald, Mark Brown,
linux-sound, Fabio Estevam, Jaroslav Kysela, linux-arm-kernel,
Weidong Wang, Liam Girdwood, linux-kernel, Chancel Liu,
Banajit Goswami, patches, linuxppc-dev
Hi
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it directly, replace it
> with what is really being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> sound/soc/generic/audio-graph-card2-custom-sample.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/generic/audio-graph-card2-custom-sample.c b/sound/soc/generic/audio-graph-card2-custom-sample.c
> index 1b6ccd2de964..8e5a51098490 100644
> --- a/sound/soc/generic/audio-graph-card2-custom-sample.c
> +++ b/sound/soc/generic/audio-graph-card2-custom-sample.c
> @@ -5,8 +5,9 @@
> // Copyright (C) 2020 Renesas Electronics Corp.
> // Copyright (C) 2020 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> //
> +#include <linux/device.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <sound/graph_card.h>
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 6/6] ASoC: samsung: Replace of_gpio.h by proper one
2024-05-30 22:58 [PATCH v1 0/6] ASoC: Drop or replace of_gpio.h Andy Shevchenko
` (4 preceding siblings ...)
2024-05-30 22:58 ` [PATCH v1 5/6] ASoC: generic: " Andy Shevchenko
@ 2024-05-30 22:58 ` Andy Shevchenko
5 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2024-05-30 22:58 UTC (permalink / raw)
To: Rob Herring, Weidong Wang, Mark Brown, Andy Shevchenko,
Uwe Kleine-König, Shenghao Ding, Marco Felsch,
Alper Nebi Yasak, Chancel Liu, Kuninori Morimoto, linux-sound,
linux-kernel, alsa-devel, patches, linuxppc-dev, imx,
linux-arm-kernel, linux-rockchip
Cc: Nicolin Chen, Fabio Estevam, Pengutronix Kernel Team,
Liam Girdwood, Shengjiu Wang, Sascha Hauer, Xiubo Li,
Takashi Iwai, James Schulman, Kevin Lu, Richard Fitzgerald,
Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela, Shawn Guo,
Sylwester Nawrocki, David Rhodes, Baojun Xu, Heiko Stuebner
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/samsung/aries_wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c
index a548ac33dd94..01716df0c842 100644
--- a/sound/soc/samsung/aries_wm8994.c
+++ b/sound/soc/samsung/aries_wm8994.c
@@ -1,11 +1,11 @@
// SPDX-License-Identifier: GPL-2.0+
#include <linux/extcon.h>
+#include <linux/gpio/consumer.h>
#include <linux/iio/consumer.h>
#include <linux/input-event-codes.h>
#include <linux/mfd/wm8994/registers.h>
#include <linux/module.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/regulator/consumer.h>
#include <sound/jack.h>
#include <sound/pcm_params.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 12+ messages in thread