From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90528C25B78 for ; Mon, 3 Jun 2024 22:26:52 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JWil5/qF; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VtSy24vrbz3cTm for ; Tue, 4 Jun 2024 08:26:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JWil5/qF; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VtSMq4p5Wz30Ts for ; Tue, 4 Jun 2024 08:00:39 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 02B41CE0F7B; Mon, 3 Jun 2024 22:00:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54BDEC2BD10; Mon, 3 Jun 2024 22:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717452035; bh=ZMS/4Gp6hXyd9fPwx/y5x+q7VhsaGgJvMHFGFXB2aCI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JWil5/qFuymosoPDATfZqx6FJDnMlkeS59q6fSB+oGtZnzLWlZsOYK17IUuX1oHS1 +ZGbOlO5XGTxStebKzleLLdP/ku6ByksYgWD6+z1Mv7KGjnwR3GMzWiuZo1J++YQBe YnonzpNdWoLK+5fnowMqG8M5MeJ10EV/gsKGvDpIY4wVIBC1HO+F/kfe8gBd+/QboZ BrnDQ+EAlvw7Yi4J9eZ6M1GbDt3y6+iqhqMKYxUzNtAOVfJ3SN/iHY1B0HdRGk77/Z OryQ3BNvB0McYwdX86nz7FOZKP/BNHRMgHpGVTqXr+aaBtJCcPNM0ORUNnE3rDopfE 4lfytT5yAufhQ== Date: Mon, 3 Jun 2024 17:00:32 -0500 From: Bjorn Helgaas To: Andy Shevchenko Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() Message-ID: <20240603220032.GA701908@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> X-Mailman-Approved-At: Tue, 04 Jun 2024 08:23:56 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Andrew Lunn , "Rafael J. Wysocki" , Heiko Stuebner , "Rafael J. Wysocki" , Takashi Iwai , Viresh Kumar , Linus Walleij , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Ben Segall , Perry Yuan , Prashant Gaikwad , Pavel Machek , Srinivas Pandruvada , linux-clk@vger.kernel.org, Kishon Vijay Abraham I , Abel Wu , linux-omap@vger.kernel.org, Vincent Guittot , Karol Herbst , Samuel Holland , Sebastian Reichel , Tvrtko Ursulin , linux-acpi@vger.kernel.org, Danilo Krummrich , Mel Gorman , linux-sunxi@lists.linux.dev, Guenter Roeck , Jean Delvare , linux-pm@vger.kernel.org, Potnuri Bharat Teja , James Morris , linux-sound@vger.kernel.org, Thomas Gleixner , platform-driver-x86@vger.kernel.org, Zhihao Cheng , Dietmar Eggemann , Niklas Cassel , Scott Branden , Greg Kroah-Hartman , Randy Dunlap , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, "Gautham R. Shenoy" , Dmitry Kasatkin , Tejun Heo , Andrew Morton , Elad Nachman , Linus Torvalds , Lukasz Luba , linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, Zefan L i , nouveau@lists.freedesktop.org, Dave Hansen , Clemens Ladisch , Mimi Zohar , Mahesh J Salgaonkar , Hu Ziji , Eric Dumazet , keyrings@vger.kernel.org, Oliver O'Halloran , linux-i2c@vger.kernel.org, Gregory Greenman , Ingo Molnar , linux-security-module@vger.kernel.org, Valentin Schneider , Corey Minyard , Gregory Clement , Lee Jones , Hugh Dickins , Jonathan Hunter , linux-rockchip@lists.infradead.org, linux-trace-kernel@vger.kernel.org, Andi Shyti , Robert Richter , Maarten Lankhorst , Brian Foster , Maxime Ripard , linux-gpio@ vger.kernel.org, Jason Baron , linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , cgroups@vger.kernel.org, Allen Pais , linux-arm-kernel@lists.infradead.org, Daniel Lezcano , Stephen Boyd , Roberto Sassu , linux-integrity@vger.kernel.org, Daniel Bristot de Oliveira , Len Brown , Heiner Kallweit , Miri Korenblit , Arseniy Krasnov , Ulf Hansson , Heikki Krogerus , Kuninori Morimoto , Alexander Shishkin , linux-pci@vger.kernel.org, Michael Turquette , Joonas Lahtinen , alsa-devel@alsa-project.org, Nuno Sa , Matthias Brugger , linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org, linux-phy@lists.infradead.org, Jiri Slaby , linux-staging@lists.linux.dev, Jernej Skrabec , Nikita Kravets , Peter Zijlstra , Chen-Yu Tsai , Abdel Alkuor , Broadcom internal kernel review list , "Naveen N. Rao" , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Paolo Abeni , "Serge E. Hallyn" , Lyude Paul , Kees Cook , Ray Jui , intel-gfx@lists.freedesktop.org, "Steven Rostedt \(Google\)" , Johannes Berg , Paul Moore , Mark Brown , Borislav Petkov , Rodrigo Vivi , Stanley Cha ng , Daniel Vetter , openipmi-developer@lists.sourceforge.net, linux-hwmon@vger.kernel.org, Sergey Shtylyov , linux-mm@kvack.org, Thinh Nguyen , linux-mmc@vger.kernel.org, Sebastian Reichel , Takashi Sakamoto , Daniel Scally , JC Kuo , Thierry Reding , Masami Hiramatsu , Sakari Ailus , "David S. Miller" , Mario Limonciello , Giovanni Cabiddu , Vignesh Raghavendra , Eric Biggers , Tony Lindgren , Takashi Iwai , David Howells , linux-ide@vger.kernel.org, Huang Rui , "H. Peter Anvin" , David Airlie , Jim Cromie , linux-leds@vger.kernel.org, Eric Snowberg , Herbert Xu , Florian Fainelli , Richard Weinberger , x86@kernel.org, qat-linux@intel.com, linux-bcachefs@vger.kernel.org, Jani Nikula , Ingo Molnar , Chunfeng Yun , Jakub Kicinski , Zhang Rui , Sebastian Hesselbarth , Thomas Zimmermann , Jiapeng Chong , Miquel Raynal , Kalle Valo , apparmor@lists.ubuntu.com, Hans de Goede , linux-mediatek@lists.infradead.org, Nicholas Piggin , Benjamin Berg , linux-tegra@vger.kernel.org, intel-xe@lists.freedesktop.org, AngeloGioacchino Del Regno , John Johansen , Liam Girdwood , netdev@vger.kernel.org, Peter De Schrijver , Kent Overstreet , Adrian Hunter , Vinod Koul , Damien Le Moal , Daniel Bristot de Oliveira , Johannes Weiner , Mathieu Desnoyers , linuxppc-dev@lists.ozlabs.org, Helge Deller , Stefan Berger Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. Looks nice, thanks for doing this. > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index ac6293c24976..2d317c7e1cea 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -210,7 +210,7 @@ void pcie_ecrc_get_policy(char *str) > { > int i; > > - i = match_string(ecrc_policy_str, ARRAY_SIZE(ecrc_policy_str), str); > + i = match_string(ecrc_policy_str, str); > if (i < 0) > return; > Acked-by: Bjorn Helgaas # drivers/pci/ > +++ b/mm/vmpressure.c > @@ -388,7 +388,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg, > > /* Find required level */ > token = strsep(&spec, ","); > - ret = match_string(vmpressure_str_levels, VMPRESSURE_NUM_LEVELS, token); > + ret = match_string(vmpressure_str_levels, token); VMPRESSURE_NUM_LEVELS looks like it's no longer used? > if (ret < 0) > goto out; > level = ret; > @@ -396,7 +396,7 @@ int vmpressure_register_event(struct mem_cgroup *memcg, > /* Find optional mode */ > token = strsep(&spec, ","); > if (token) { > - ret = match_string(vmpressure_str_modes, VMPRESSURE_NUM_MODES, token); > + ret = match_string(vmpressure_str_modes, token); Ditto. > if (ret < 0) > goto out; > mode = ret;