* [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64
[not found] <20240531091926.3324847-1-qianbin.zheng@nokia-sbell.com>
@ 2024-06-03 1:46 ` Qianbin Zheng (NSB)
2024-06-03 6:41 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Qianbin Zheng (NSB) @ 2024-06-03 1:46 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de
Turn on usb snooping on PPC64.
Signed-off-by: Qianbin Zheng <qianbin.zheng@nokia-sbell.com>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index 3432ebfae978..a0f3498086d5 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -328,7 +328,7 @@ static int dr_controller_setup(struct fsl_udc *udc)
__raw_writel(ctrl, &usb_sys_regs->control);
}
-#if defined(CONFIG_PPC32) && !defined(CONFIG_NOT_COHERENT_CACHE)
+#if (defined(CONFIG_PPC32) || (defined(CONFIG_PPC64))) && !defined(CONFIG_NOT_COHERENT_CACHE)
/* Turn on cache snooping hardware, since some PowerPC platforms
* wholly rely on hardware to deal with cache coherent. */
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64
2024-06-03 1:46 ` [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64 Qianbin Zheng (NSB)
@ 2024-06-03 6:41 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2024-06-03 6:41 UTC (permalink / raw)
To: Qianbin Zheng (NSB)
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de
On Mon, Jun 03, 2024 at 01:46:50AM +0000, Qianbin Zheng (NSB) wrote:
> Turn on usb snooping on PPC64.
This says what you are doing, but not _why_ you are doing it?
What changed to allow this to now work properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-03 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240531091926.3324847-1-qianbin.zheng@nokia-sbell.com>
2024-06-03 1:46 ` [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64 Qianbin Zheng (NSB)
2024-06-03 6:41 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).