From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34398C27C53 for ; Wed, 12 Jun 2024 21:33:51 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=J4gew7GX; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VzzLj0wT0z3cX2 for ; Thu, 13 Jun 2024 07:33:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=J4gew7GX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VzzKw5KDWz3bqC for ; Thu, 13 Jun 2024 07:33:08 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C593661740; Wed, 12 Jun 2024 21:33:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B31DEC116B1; Wed, 12 Jun 2024 21:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718227987; bh=D7/e9lxK/rDnF5q2wBJbSwFKBep+OjF1zHYFBRsOwHY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J4gew7GXSUxZyxXl6G49+4erFfWm/fvqP8jJMq7QuXBUHyR17gKVbI8IJ3y71epYo 81Eq4piaIn37sHAKw45pOJJnpiTeuc2KSFxdSD1+2LioYDUAwYQQ8KGiGECKgXZ1Bt BQIkYrv1Z3RNFkSAHVf81GTPLI5u7plWmLvmv2tSr8XWK2kuYVByujH0Xm2sSG3rLe dcH3Q/OlBdRCiuZINoD5hS74CGC35ok/tQmpHn36JG4CCNQB6ctPj6kIhn5MA8jO7+ XDUBrtlraXPQiItIjFfHu36XD/1shI91JiWJHwx90qz33buNQ2dew6BWeH46IO/yU8 gdQU9P2cQi32g== Date: Wed, 12 Jun 2024 14:33:05 -0700 From: Jakub Kicinski To: Julia Lawall Subject: Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback Message-ID: <20240612143305.451abf58@kernel.org> In-Reply-To: <20240609082726.32742-1-Julia.Lawall@inria.fr> References: <20240609082726.32742-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Neil Brown , Lai Jiangshan , Olga Kornievskaia , kernel-janitors@vger.kernel.org, Dai Ngo , Christophe Leroy , coreteam@netfilter.org, "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, "Paul E . McKenney" , bridge@lists.linux.dev, ecryptfs@vger.kernel.org, Nicholas Piggin , linux-can@vger.kernel.org, Tom Talpey , Mathieu Desnoyers , Vlastimil Babka , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, wireguard@lists.zx2c4.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, 9 Jun 2024 10:27:12 +0200 Julia Lawall wrote: > Since SLOB was removed, it is not necessary to use call_rcu > when the callback only performs kmem_cache_free. Use > kfree_rcu() directly. > > The changes were done using the following Coccinelle semantic patch. > This semantic patch is designed to ignore cases where the callback > function is used in another way. How does the discussion on: [PATCH] Revert "batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks" https://lore.kernel.org/all/20240612133357.2596-1-linus.luessing@c0d3.blue/ reflect on this series? IIUC we should hold off..