linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.ibm.com>
To: Anjali K <anjalik@linux.ibm.com>
Cc: kees@kernel.org, naveen@kernel.org, christophe.leroy@csgroup.eu,
	gustavoars@kernel.org, npiggin@gmail.com, vishalc@linux.ibm.com,
	linuxppc-dev@lists.ozlabs.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace
Date: Mon, 17 Jun 2024 16:07:04 +0530	[thread overview]
Message-ID: <20240617103704.GA767455@linux.ibm.com> (raw)
In-Reply-To: <20240614173844.746818-1-anjalik@linux.ibm.com>

> Commit 6d07d1cd300f ("usercopy: Restrict non-usercopy caches to size 0")
> requires that only whitelisted areas in slab/slub objects can be copied to
> userspace when usercopy hardening is enabled using CONFIG_HARDENED_USERCOPY.
> Dtl contains hypervisor dispatch events which are expected to be read by
> privileged users. Hence mark this safe for user access.
> Specify useroffset=0 and usersize=DISPATCH_LOG_BYTES to whitelist the
> entire object.
> 
> Co-developed-by: Vishal Chourasia <vishalc@linux.ibm.com>
> Signed-off-by: Vishal Chourasia <vishalc@linux.ibm.com>
> Signed-off-by: Anjali K <anjalik@linux.ibm.com>
> ---
>  arch/powerpc/platforms/pseries/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju

  reply	other threads:[~2024-06-17 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 17:38 [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace Anjali K
2024-06-17 10:37 ` Srikar Dronamraju [this message]
2024-06-17 17:59 ` Kees Cook
2024-06-18  7:11   ` Michael Ellerman
2024-06-21  8:12     ` Anjali K
2024-06-21 11:38       ` Michael Ellerman
2024-06-20 17:28   ` Anjali K
2024-06-20 18:59     ` Kees Cook
2024-06-24 12:30 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240617103704.GA767455@linux.ibm.com \
    --to=srikar@linux.ibm.com \
    --cc=anjalik@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=naveen@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=vishalc@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).