From: Kees Cook <kees@kernel.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Uros Bizjak <ubizjak@gmail.com>,
linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
David Airlie <airlied@gmail.com>, Wei Liu <wei.liu@kernel.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Dexuan Cui <decui@microsoft.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Petr Mladek <pmladek@suse.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
John Ogness <john.ogness@linutronix.de>,
Jani Nikula <jani.nikula@intel.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Richard Weinberger <richard@nod.at>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] printk: Add a short description string to kmsg_dump()
Date: Fri, 28 Jun 2024 09:42:06 -0700 [thread overview]
Message-ID: <202406280938.2D7BB97C@keescook> (raw)
In-Reply-To: <06899fda-de75-4d44-bda5-dcbb3e35d037@redhat.com>
On Fri, Jun 28, 2024 at 09:13:11AM +0200, Jocelyn Falempe wrote:
> It is present in the kdump log, but before all the register dumps.
> So to retrieve it you need to parse the last 30~40 lines of logs, and search
> for a line starting with "Kernel panic - not syncing".
> https://elixir.bootlin.com/linux/v6.10-rc5/source/kernel/panic.c#L341
> But I think that's a bit messy, and I prefer having a kmsg_dump parameter.
Yeah, I totally agree: it should be easy to access the panic reason. I
just wanted to double-check that from pstore's perspective there wasn't
any "new" information here that should be captured somehow.
Thanks!
--
Kees Cook
prev parent reply other threads:[~2024-06-28 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:39 [PATCH] printk: Add a short description string to kmsg_dump() Jocelyn Falempe
2024-06-26 8:00 ` Petr Mladek
2024-06-27 7:29 ` Jocelyn Falempe
2024-06-26 16:26 ` Kees Cook
2024-06-28 7:13 ` Jocelyn Falempe
2024-06-28 16:42 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406280938.2D7BB97C@keescook \
--to=kees@kernel.org \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@ffwll.ch \
--cc=decui@microsoft.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jani.nikula@intel.com \
--cc=jfalempe@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=kys@microsoft.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=tzimmermann@suse.de \
--cc=ubizjak@gmail.com \
--cc=vigneshr@ti.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).