From: Greg KH <gregkh@linuxfoundation.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: ajd@linux.ibm.com, arnd@arndb.de, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, manoj@linux.vnet.ibm.com,
imunsie@au1.ibm.com, fbarrat@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, clombard@linux.vnet.ibm.com
Subject: Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()
Date: Tue, 9 Jul 2024 15:32:50 +0200 [thread overview]
Message-ID: <2024070940-customize-sturdily-fc81@gregkh> (raw)
In-Reply-To: <20240709131754.855144-1-make24@iscas.ac.cn>
On Tue, Jul 09, 2024 at 09:17:54PM +0800, Ma Ke wrote:
> In read_handle() of_get_address() may return NULL which is later
> dereferenced. Fix this bug by adding NULL check.
>
> Cc: stable@vger.kernel.org
> Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/misc/cxl/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c
> index bcc005dff1c0..d8dbb3723951 100644
> --- a/drivers/misc/cxl/of.c
> +++ b/drivers/misc/cxl/of.c
> @@ -58,7 +58,7 @@ static int read_handle(struct device_node *np, u64 *handle)
>
> /* Get address and size of the node */
> prop = of_get_address(np, 0, &size, NULL);
> - if (size)
> + if (!prop || size)
> return -EINVAL;
How was this issue found?
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-09 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 13:17 [PATCH] cxl: Fix possible null pointer dereference in read_handle() Ma Ke
2024-07-09 13:32 ` Greg KH [this message]
2024-07-09 13:48 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070940-customize-sturdily-fc81@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=make24@iscas.ac.cn \
--cc=manoj@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).