From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE349C3DA49 for ; Thu, 18 Jul 2024 08:03:44 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OlB6nsD5; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WPlgM1ZLpz3cXL for ; Thu, 18 Jul 2024 18:03:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OlB6nsD5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::226; helo=relay6-d.mail.gandi.net; envelope-from=luca.ceresoli@bootlin.com; receiver=lists.ozlabs.org) Received: from relay6-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WPkBh55DTz3cHP for ; Thu, 18 Jul 2024 16:57:13 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 66B00C0011; Thu, 18 Jul 2024 06:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1721285821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgZHkXL2FGs1/bjZPDSboGR72yBe//NfgloPvNTjUQ0=; b=OlB6nsD5RtGZmYjd7bhjEoZx7QMkbbOT8V45YhxxCFz4y2iiCJe+cf2PVPl+VsXD6UUMqk Yc28bGhZQ13OubzP5CW/pjPqqFo91MRM0eVoREVGLvn0MLgNZy6pPxquFKWhNBkv4SbFT2 sax9ioW5vC5M5bokQz4XncM9ZdU0GCDemzBwA+l1XJdTnXTEUKHI48dxPqMAjv00+G3aQG rBXI5/ojqb79XSjovNP74Rn6wSf1My85vfzfK9OmlUEoc3d8vGPg+knHhqSD5yHTRQLUcZ BDxiKiWHxBRawYhcLiwX+N2Krj0xmgk4IRTokaqbJaztXMntEG+p6mo1v3ON7A== Date: Thu, 18 Jul 2024 08:56:51 +0200 From: Luca Ceresoli To: Stephen Boyd Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32() Message-ID: <20240718085651.63ddfb20@booty> In-Reply-To: <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org> References: <20240717-of_property_for_each_u32-v2-1-4060990f49c9@bootlin.com> <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com X-Mailman-Approved-At: Thu, 18 Jul 2024 18:03:04 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-riscv@lists.infradead.org, Alexandre Belloni , Lee Jones , Jacky Bai , Liam Girdwood , Tony Lindgren , Linus Walleij , llvm@lists.linux.dev, Richard Leitner , Jaroslav Kysela , Thomas Petazzoni , devicetree@vger.kernel.org, patches@opensource.cirrus.com, Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= , Jernej Skrabec , Alim Akhtar , Ghennadi Procopciuc , Fabio Estevam , Lars-Peter Clausen , Rob Herring , Doug Berger , Florian Fainelli , Aaro Koskinen , Emilio =?UTF-8?Q?L=C3=B3pez?= , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Christophe Leroy , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Chen-Yu Tsai , Andreas Kemnade , Broadcom internal kernel review list , linux-serial@vger.kernel.org, Andre Przywara , Miguel Ojeda , Bartosz Golaszewski , linux-usb@vger.kernel.org, Michael Turquette , Dong Aisheng , "Peng Fan \(OSS\)" , linux-arm-msm@vger.kernel.org, Nicolas Ferre , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Nathan Chancellor , "Naveen N. Rao" , Richard Fitzgerald , Damien Le Moal , linux-pwm@vger.kernel.org, linux-sound@vger.kernel.org, Jonathan Cameron , Krzysztof Kozlowski , Takashi Iwai , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chester Lin , Roger Quadros , Matthias Brugger , Saravana Kannan , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , Bjorn Andersson , Samuel Holland , Claudiu Beznea , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Thomas Gleixner , Pengutronix Kernel Team , Kevin Hilman , Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= , Shawn Guo , linux-sunxi@lists.linux.dev, Jonathan Cameron Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello Stephen, On Wed, 17 Jul 2024 16:33:34 -0700 Stephen Boyd wrote: > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client, > > * property silabs,pll-source : , [<..>] > > * allow to selectively set pll source > > */ > > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) { > > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4); > > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */ > > + if (sz < 0) > > + return dev_err_probe(&client->dev, sz, "invalid pll-source"); > > Needs a newline on the printk message. Ouch! Fix queued for v3. Thanks, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com