From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E876C3DA7F for ; Wed, 31 Jul 2024 08:12:54 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=U41CFM22; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WYlFx1Sg5z3d8G for ; Wed, 31 Jul 2024 18:12:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=U41CFM22; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ventanamicro.com (client-ip=2a00:1450:4864:20::52d; helo=mail-ed1-x52d.google.com; envelope-from=ajones@ventanamicro.com; receiver=lists.ozlabs.org) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WYlDW4Gf1z3d9t for ; Wed, 31 Jul 2024 18:11:39 +1000 (AEST) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5af326eddb2so1183477a12.1 for ; Wed, 31 Jul 2024 01:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722413496; x=1723018296; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1i19l7d1eZbhVp7fQ4bZoRAfF6lLDsSZcH8bPmRvWiA=; b=U41CFM22ICBVLxsEh4MXmTlnGoK/yTJTtUdIdpMeWNIKAlXukjJVudj4Q1IuOjhU97 9tNYUTw7oofFapoOS5k3BVdrA4vWw57jYPTwhXOkhSjQTVeUxJelRWvIFBCut0Kzfpp4 1Ogw+azd/5qPMBp8R5nTPDh85EM/clvH200lZJt7fz/LLBN4atzvnBZxNLFrAYLJi18h J92IWOVZCGyAMOFuHdw1UbtAnxJRDXwUaSU0jCcaTyO8QcMWpxP7Fb4C1uxnogAv6V4d dAZf+wlpR0br7ZaSWjIDcmE8A+bghKkWV1HRAwMejc7kY9vkrkQJ4oS3XTYF19yBDLmk 59OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722413496; x=1723018296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1i19l7d1eZbhVp7fQ4bZoRAfF6lLDsSZcH8bPmRvWiA=; b=nqo2apB2TFdQ//Fo+G/KeGvXgkOp4Z/UIXUGIy1zH7QbZj5F8fFCbIW5b+Qptc2OY9 IE9IJs1OXSiJ5UV6KhAlDhEH1CL2+E9xaZ1J5I6nxXPwa9mxYxIZ9jTJhu3p9rOLq6a2 5IDk9bG49Gw5fmDcaMHPLYkcdc1HFqfgF2J2dV8BwOBXAwp5DIB3ZMHE8ciEptZW+roj 68Ali9Xvwuk1vrrlcjyFDubEPU9l44jDR8LCzp3k5HxTFgU6PvXZ+1G/kMmVXlfsTjOd WTMQvLvWbfepC5rM//kyNAll7pussd/0xOvx6TzsKEfV3+KWIXIDA+NRHm4Y/dpUx8qP h1lw== X-Forwarded-Encrypted: i=1; AJvYcCVpsX3R4zYRtOQ/W3A73R2ugBz7RByNXCKC3Ltr7PxjzXlviD5Bj+3Yeo5+LaHp7tEIE1qoxx2N9IRRFKqSb2h57NX34hjxK9OogsyszA== X-Gm-Message-State: AOJu0YxJdKwYO1xBZjO4wcG9fYtWbPMnDjyt5XW4qv/kWV2/RTvbls6C LpVn/lzV1PTkiZ6ProjBMpEzXFOSwzLKAYmamfQNGVp1XiXz6R7/fDqVO0in/SA= X-Google-Smtp-Source: AGHT+IEAM3rgFV5Nss1oeOJc4d0T/p6GjpLY5HpQ/UfV3bepvtCwNBml7jly3uQHrfiUKxZe0LrJkQ== X-Received: by 2002:a17:907:60cb:b0:a7d:88c4:2897 with SMTP id a640c23a62f3a-a7d88c437b8mr269366466b.2.1722413495475; Wed, 31 Jul 2024 01:11:35 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acadb8361sm734690366b.207.2024.07.31.01.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 01:11:35 -0700 (PDT) Date: Wed, 31 Jul 2024 10:11:34 +0200 From: Andrew Jones To: Sean Christopherson Subject: Re: [PATCH v12 56/84] KVM: RISC-V: Mark "struct page" pfns dirty iff a stage-2 PTE is installed Message-ID: <20240731-0456655970f6ae99f907de43@orel> References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-57-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726235234.228822-57-seanjc@google.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , linux-riscv@lists.infradead.org, Claudio Imbrenda , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , David Stevens , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jul 26, 2024 at 04:52:05PM GMT, Sean Christopherson wrote: > Don't mark pages dirty if KVM bails from the page fault handler without > installing a stage-2 mapping, i.e. if the page is guaranteed to not be > written by the guest. > > In addition to being a (very) minor fix, this paves the way for converting > RISC-V to use kvm_release_faultin_page(). > > Signed-off-by: Sean Christopherson > --- > arch/riscv/kvm/mmu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index b63650f9b966..06aa5a0d056d 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -669,7 +669,6 @@ int kvm_riscv_gstage_map(struct kvm_vcpu *vcpu, > goto out_unlock; > > if (writable) { > - kvm_set_pfn_dirty(hfn); > mark_page_dirty(kvm, gfn); > ret = gstage_map_page(kvm, pcache, gpa, hfn << PAGE_SHIFT, > vma_pagesize, false, true); > @@ -682,6 +681,9 @@ int kvm_riscv_gstage_map(struct kvm_vcpu *vcpu, > kvm_err("Failed to map in G-stage\n"); > > out_unlock: > + if ((!ret || ret == -EEXIST) && writable) > + kvm_set_pfn_dirty(hfn); > + > spin_unlock(&kvm->mmu_lock); > kvm_set_pfn_accessed(hfn); > kvm_release_pfn_clean(hfn); > -- > 2.46.0.rc1.232.g9752f9e123-goog > Reviewed-by: Andrew Jones