From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55C82C3DA7F for ; Wed, 31 Jul 2024 08:13:35 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=iUDqCcP9; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WYlGk0XR8z3cjX for ; Wed, 31 Jul 2024 18:13:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=iUDqCcP9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ventanamicro.com (client-ip=2a00:1450:4864:20::52f; helo=mail-ed1-x52f.google.com; envelope-from=ajones@ventanamicro.com; receiver=lists.ozlabs.org) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WYlFc0m6fz3dBq for ; Wed, 31 Jul 2024 18:12:35 +1000 (AEST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc34431so4295206a12.0 for ; Wed, 31 Jul 2024 01:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722413552; x=1723018352; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=iUDqCcP9x8XbDLBLPQAtHMlzO92pd9XpH7JaxGLf3MsrKv2RewHjL5Wd1X3CwcdISk m6T1dFzeqsX3+pL5jyVEJc6wRe8VxTJ/Vjoiac2rK4f5/rY7VDgBPD8H+MAmylXmMv2l LbJc9Q+ubln0xAmgMjryCM9Jx5UpdoNLWxSc90zr14j8DF10OFkJVf/dvXqZZxLDPr1F BqwVvdXbW8dcmogHs4RarL9aD/FHTAb1TMZmj3fapGsIq0fIpoBl8+vgamSS8Bzg4bbN IJazosqRi8jVDQu6tbqYwN3AsBlrnHQlavj5m6R9Q7xaCmz1JqNcKas84zCAvvm0fIts eepQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722413552; x=1723018352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=As8ohSjqclqvk184nGSytZ4S6LOtqmeEAB3JkVbt8D1Jx9pLFl6hSYuetbrh7YIzuZ WOampVLOQYTuCDxOG40bXJrEsZ8FTpkWwtsdgHj8KWJYkXLjxDL1RIl8+CeIVQIMfWGs dltgRGdXK0S4aNIzbg2fnu535j3j2RXFTy7rOnR5Z4VooOq+LptMDVbjy9g7iPXRtt+h fOR0hmEYrOQWWf2l0zC6m458VrmXq+vel4bkSSVDNk0PEy6IXs4o1wMv4YjOMNBTFLPM NfnIRO75TTeJ7yc3NSm32jrMwiCPjTUaYu6e0MR5R1hG7zrK0ZegF6YQcuVOO4yJ1S/5 jSFw== X-Forwarded-Encrypted: i=1; AJvYcCWH+83VWBe3vIeOF1pl82NZigtwcqRLHizc1d42QJh5ICP8XNGo/Ae1lsJ8S01QjXaeRm1C+sGU36FOFpsew5x2Ns5jap+2CiGIV9B2+A== X-Gm-Message-State: AOJu0YwK2ASOQO4QjDBDcmKaizc5kV/iXTIfvmCxJ0bS43hgqp7G78IF bJtSNT1lJrnJVf71hbNI6tFg/EGaJTsxkGxoD0tfV3SDCFbww/wCekD/ivrVfbA= X-Google-Smtp-Source: AGHT+IGxlRCnb+W6DiXG7nTnr6lyiGJnx0i1YWV+5ADomMCnBj37OyG82iPSl5g4jXJI8y3klQMjSg== X-Received: by 2002:a50:d7c1:0:b0:57d:3df:f881 with SMTP id 4fb4d7f45d1cf-5b021190495mr11744615a12.3.1722413552263; Wed, 31 Jul 2024 01:12:32 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac60918cb4sm8394451a12.0.2024.07.31.01.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 01:12:31 -0700 (PDT) Date: Wed, 31 Jul 2024 10:12:31 +0200 From: Andrew Jones To: Sean Christopherson Subject: Re: [PATCH v12 57/84] KVM: RISC-V: Mark "struct page" pfns accessed before dropping mmu_lock Message-ID: <20240731-f034f3516f0fffede877c68d@orel> References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-58-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726235234.228822-58-seanjc@google.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , linux-riscv@lists.infradead.org, Claudio Imbrenda , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , David Stevens , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jul 26, 2024 at 04:52:06PM GMT, Sean Christopherson wrote: > Mark pages accessed before dropping mmu_lock when faulting in guest memory > so that RISC-V can convert to kvm_release_faultin_page() without tripping > its lockdep assertion on mmu_lock being held. Marking pages accessed > outside of mmu_lock is ok (not great, but safe), but marking pages _dirty_ > outside of mmu_lock can make filesystems unhappy. > > Signed-off-by: Sean Christopherson > --- > arch/riscv/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 06aa5a0d056d..806f68e70642 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -683,10 +683,10 @@ int kvm_riscv_gstage_map(struct kvm_vcpu *vcpu, > out_unlock: > if ((!ret || ret == -EEXIST) && writable) > kvm_set_pfn_dirty(hfn); > + else > + kvm_release_pfn_clean(hfn); > > spin_unlock(&kvm->mmu_lock); > - kvm_set_pfn_accessed(hfn); > - kvm_release_pfn_clean(hfn); > return ret; > } > > -- > 2.46.0.rc1.232.g9752f9e123-goog > Reviewed-by: Andrew Jones