From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A1AAC3DA64 for ; Wed, 31 Jul 2024 08:45:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZfJyoowh; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WYlzZ5m5Xz3clp for ; Wed, 31 Jul 2024 18:45:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZfJyoowh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WYlyq02qrz3c8x for ; Wed, 31 Jul 2024 18:44:50 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6484862274; Wed, 31 Jul 2024 08:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5647C116B1; Wed, 31 Jul 2024 08:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722415488; bh=WzC80hl1AW1tiBkiKAI6/dELkDarMZZqpTulR3LSY6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZfJyoowhJ0sxAIFJP8EH8/5EeNk5XFa+k/rD9fPPqt89+baW6O46DfPVbZHwu06z4 vUYjpNjYSV+X976z7l28rQZ5LswYHGqZ+GERZq076T5w3mHwLSfZQtYNyD7txtZU+6 lyVixwyfS4Qzu6d0QtITvrqZ7CjxFVYoFz/I/KpXaopCd1xUNdHvtyRTZfU5rogwud sQzATIetOuPz2X7ltmYAL0zW1qY6wBeHFAMnLzBFWQgTwtOrpSaEr3WCjtyCZTu+M9 YX5QW8mtHcV8yjGjccDem99PPL5YUzsAXOi6bOz5H13AQHfJhFSOTuGLrriW6NXNoX 1YQf5cUB3m49Q== Date: Wed, 31 Jul 2024 09:44:43 +0100 From: Simon Horman To: Herve Codina Subject: Re: [PATCH net v1] net: wan: fsl_qmc_hdlc: Discard received CRC Message-ID: <20240731084443.GL1967603@kernel.org> References: <20240730063133.179598-1-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730063133.179598-1-herve.codina@bootlin.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy , Eric Dumazet , stable@vger.kernel.org, Thomas Petazzoni , Jakub Kicinski , Paolo Abeni , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 30, 2024 at 08:31:33AM +0200, Herve Codina wrote: > Received frame from QMC contains the CRC. > Upper layers don't need this CRC and tcpdump mentioned trailing junk > data due to this CRC presence. > > As some other HDLC driver, simply discard this CRC. It might be nice to specifically site an example. But yes, I see this pattern in hdlc_rx_done(). > > Fixes: d0f2258e79fd ("net: wan: Add support for QMC HDLC") > Cc: stable@vger.kernel.org > Signed-off-by: Herve Codina > --- > drivers/net/wan/fsl_qmc_hdlc.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman