linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arch: powerpc: Use backlight power constants
@ 2024-07-31 13:06 Thomas Zimmermann
  2024-07-31 13:06 ` [PATCH 1/2] " Thomas Zimmermann
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2024-07-31 13:06 UTC (permalink / raw)
  To: mpe, christophe.leroy, npiggin, naveen; +Cc: linuxppc-dev, Thomas Zimmermann

Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for
power states") introduced dedicated constants for backlight power states.
Convert PowerPC code to the new constants.

The new constants replace the fbdev constants. This is part of a larger
effort to make kernel subsystems more independent from fbdev code and
headers.

Thomas Zimmermann (2):
  arch: powerpc: Use backlight power constants
  macintosh/pmubl: Use backlight power constants

 arch/powerpc/kernel/traps.c           | 2 +-
 drivers/macintosh/via-pmu-backlight.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arch: powerpc: Use backlight power constants
  2024-07-31 13:06 [PATCH 0/2] arch: powerpc: Use backlight power constants Thomas Zimmermann
@ 2024-07-31 13:06 ` Thomas Zimmermann
  2024-07-31 13:06 ` [PATCH 2/2] macintosh/pmubl: " Thomas Zimmermann
  2024-08-12 12:01 ` [PATCH 0/2] arch: powerpc: " Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2024-07-31 13:06 UTC (permalink / raw)
  To: mpe, christophe.leroy, npiggin, naveen; +Cc: linuxppc-dev, Thomas Zimmermann

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 arch/powerpc/kernel/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 28d6472c380a..edf5cabe5dfd 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -121,7 +121,7 @@ static void pmac_backlight_unblank(void)
 
 		props = &pmac_backlight->props;
 		props->brightness = props->max_brightness;
-		props->power = FB_BLANK_UNBLANK;
+		props->power = BACKLIGHT_POWER_ON;
 		backlight_update_status(pmac_backlight);
 	}
 	mutex_unlock(&pmac_backlight_mutex);
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] macintosh/pmubl: Use backlight power constants
  2024-07-31 13:06 [PATCH 0/2] arch: powerpc: Use backlight power constants Thomas Zimmermann
  2024-07-31 13:06 ` [PATCH 1/2] " Thomas Zimmermann
@ 2024-07-31 13:06 ` Thomas Zimmermann
  2024-08-12 12:01 ` [PATCH 0/2] arch: powerpc: " Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2024-07-31 13:06 UTC (permalink / raw)
  To: mpe, christophe.leroy, npiggin, naveen; +Cc: linuxppc-dev, Thomas Zimmermann

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/macintosh/via-pmu-backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 89450645c230..26bd9ed5e664 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -178,7 +178,7 @@ void __init pmu_backlight_init(void)
 	}
 
 	bd->props.brightness = level;
-	bd->props.power = FB_BLANK_UNBLANK;
+	bd->props.power = BACKLIGHT_POWER_ON;
 	backlight_update_status(bd);
 
 	printk(KERN_INFO "PMU Backlight initialized (%s)\n", name);
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] arch: powerpc: Use backlight power constants
  2024-07-31 13:06 [PATCH 0/2] arch: powerpc: Use backlight power constants Thomas Zimmermann
  2024-07-31 13:06 ` [PATCH 1/2] " Thomas Zimmermann
  2024-07-31 13:06 ` [PATCH 2/2] macintosh/pmubl: " Thomas Zimmermann
@ 2024-08-12 12:01 ` Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2024-08-12 12:01 UTC (permalink / raw)
  To: mpe, christophe.leroy, npiggin, naveen, Thomas Zimmermann; +Cc: linuxppc-dev

On Wed, 31 Jul 2024 15:06:13 +0200, Thomas Zimmermann wrote:
> Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for
> power states") introduced dedicated constants for backlight power states.
> Convert PowerPC code to the new constants.
> 
> The new constants replace the fbdev constants. This is part of a larger
> effort to make kernel subsystems more independent from fbdev code and
> headers.
> 
> [...]

Applied to powerpc/next.

[1/2] arch: powerpc: Use backlight power constants
      https://git.kernel.org/powerpc/c/28455894bb99a1afe541cb7c987cc7e193c41fc6
[2/2] macintosh/pmubl: Use backlight power constants
      https://git.kernel.org/powerpc/c/c7907a47bb68a18758edf12fd45e201ff03e2acc

cheers


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-08-12 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 13:06 [PATCH 0/2] arch: powerpc: Use backlight power constants Thomas Zimmermann
2024-07-31 13:06 ` [PATCH 1/2] " Thomas Zimmermann
2024-07-31 13:06 ` [PATCH 2/2] macintosh/pmubl: " Thomas Zimmermann
2024-08-12 12:01 ` [PATCH 0/2] arch: powerpc: " Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).