linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Cc: christophe.leroy2@cs-soprasteria.com,
	David Miller <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: linux-next: build failure after merge of the net-next tree
Date: Fri, 13 Sep 2024 11:36:19 -0700	[thread overview]
Message-ID: <20240913113619.4bf2bf16@kernel.org> (raw)
In-Reply-To: <CAHS8izPf29T51QB4u46NJRc=C77vVDbR1nXekJ5-ysJJg8fK8g@mail.gmail.com>

On Fri, 13 Sep 2024 09:27:17 -0700 Mina Almasry wrote:
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 5769fe6e4950..ea4005d2d1a9 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -239,8 +239,8 @@ static inline unsigned long _compound_head(const
> struct page *page)
>  {
>         unsigned long head = READ_ONCE(page->compound_head);
> 
> -       if (unlikely(head & 1))
> -               return head - 1;
> +       if (unlikely(head & 1UL))
> +               return head & ~1UL;
>         return (unsigned long)page_fixed_fake_head(page);
>  }
> 
> Other than that I think this is a correct fix. Jakub, what to do here.
> Do I send this fix to the mm tree or to net-next?

Yes, please, send this out and CC all the relevant people.
We can decide which tree it will go into once its reviewed.

Stephen, would you be willing to slap this on top of linux-next for now?
I can't think of a better bandaid we could put in net-next,
and it'd be sad to revert a major feature because of a compiler bug(?)


  reply	other threads:[~2024-09-13 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240913125302.0a06b4c7@canb.auug.org.au>
     [not found] ` <20240912200543.2d5ff757@kernel.org>
     [not found]   ` <20240913204138.7cdb762c@canb.auug.org.au>
2024-09-13 15:34     ` linux-next: build failure after merge of the net-next tree Jakub Kicinski
2024-09-13 15:49       ` Jakub Kicinski
2024-09-13 16:13         ` LEROY Christophe
2024-09-13 16:27           ` Mina Almasry
2024-09-13 18:36             ` Jakub Kicinski [this message]
2024-09-13 20:05               ` Mina Almasry
2024-09-13 20:24                 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913113619.4bf2bf16@kernel.org \
    --to=kuba@kernel.org \
    --cc=almasrymina@google.com \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy2@cs-soprasteria.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).