From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D1BCCED24E for ; Tue, 8 Oct 2024 00:55:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XMyGx6q1qz2yN8; Tue, 8 Oct 2024 11:55:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=139.178.84.217 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728348905; cv=none; b=GTZcwCdffS6JnigsfwewkJZRFgU/UPy8LVWVcGkmOx/9Jy/rc9jGUNrxqWrFNas0LKU5bqPZmN5FOzHESgVsX2DHydckSmYhZqrts2jhEh36Qa5K8z+wlJvrAg5r5HH8uBlXeza8mbTzicKJdYTEc4BqDd3Rp+57weeAuVzV30V7MgnZRqPg2vfAAyzi/MOk/FbxHzS8uI57kaLTad5ig1bIqQf+qwSs14FrSrdxI6vqRnD2s3A4XAPghslVuaHQrQ42OhsEIayJ+AUTJGAC2gAnM0PZSBPfN9OUpeSdz1SQfL2riUeUdaAkT1hEWbsYydzkRfcBU1LgfNwXzmmofw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728348905; c=relaxed/relaxed; bh=O1OrairncSGdcGoFvlY4mSqBqXBQ7N0yPJWQn/POrHA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QzrXDZW6cUTfrxs7I1g1N/KlpiPniGqUy7ab/P2BJkq1PToqn/LOuGvd8uvRCS+N6t3/OkCbbp9wwGHqa/WHiNY4D3RX0wvOMD7V2snbcXsRRzHVekBiji67lThGRisJ4XhkvvijUzKzp+vCWXTroydzyypiJlssBpd+8tEU/U6OIC4EONPcqmdkj9EiGGgLELqaW3oz8fXtrG/I5XbsWd/RX+0lciN4j475WS42Px5fKPMf72bJRtPNUZAPhiFaQPTojFEKOzKTsn/ViHifSpSXtV1CMM9OTsdLMVmU0mj0GKpMMa7y6YklMpN4VuNzfYK+7ucEBOe2+7gqdQk0kw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=srs0=jrpr=re=goodmis.org=rostedt@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=srs0=jrpr=re=goodmis.org=rostedt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XMyGw00Vcz2yMv for ; Tue, 8 Oct 2024 11:55:03 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0C9975C5D9A; Tue, 8 Oct 2024 00:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36669C4CEC6; Tue, 8 Oct 2024 00:54:57 +0000 (UTC) Date: Mon, 7 Oct 2024 20:54:58 -0400 From: Steven Rostedt To: LKML , Linux Trace Kernel , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "linux-arch@vger.kernel.org" , "x86@kernel.org" Cc: Masami Hiramatsu , Mathieu Desnoyers , Mark Rutland , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use Message-ID: <20241007205458.2bbdf736@gandalf.local.home> In-Reply-To: <20241007204743.41314f1d@gandalf.local.home> References: <20241007204743.41314f1d@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 7 Oct 2024 20:47:43 -0400 Steven Rostedt wrote: > +#ifndef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS > +struct __arch_ftrace_regs { > + struct pt_regs regs; > +}; > + > +#define arch_ftrace_get_regs(fregs) \ > + ({ struct __arch_fregs_regs *__f = (struct __arch_ftrace_regs *)(fregs); \ > + &__f->regs; \ > + }) I wrote the arch_ftrace_get_regs() at the start of creating this patch. > + > +struct ftrace_regs; > +#define arch_ftrace_regs(fregs) ((struct __arch_ftrace_regs *)(fregs)) > + I just realized I can simplify it with: #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs)->regs; }) I may send a v2 (tomorrow). -- Steve