From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E89D5CFC5EC for ; Thu, 10 Oct 2024 18:25:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XPdTN4Bqrz3bkd; Fri, 11 Oct 2024 05:24:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::649" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728584696; cv=none; b=POHONm2LKpJT39EqlPYajpRg7Uv+CFAHlGFMoNesXxTAjiJR6gzw68J4ugqTHlVVMLKI8N6gNK94Sb9E1F+DzKmYXAujC1rdSgNtk+7Skg6yegdpZv3z5WN2zMNCTeaYlkGy3ZkQ/zoeNxe4uDFIAdZqvV0Y2Eemf96R6tiER4qQ9nRrvTHCl0LlXZ77uDJO8dJ31psFLzZ/rtdGaR2GrQjZ0atz0ZBtqT+MkphtVgnwXG4qlfLoSUGfgmx0hvy5LK8a8PwY4EVgR7Enm8yPFBG1CiT3LNBZFqGRDDwZWLqEGj+cDLUABZE/tAQOLWDfIlrG55OgCylNHoQ7N7byqw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728584696; c=relaxed/relaxed; bh=yUMe47Ku2d+lU53n+UV6eA4G9zH9pOaBnB7PUsg7n0E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=F+Wv8TRppEQmJvd394Sgzd4KYuKUINpJlJgmjbG3RxiBzbgQmfLgvfJEhfMf6RMuVQbufuURDGz558sAkT8bannCSgpD8Qa6QidP1hNbsMabEiUn+pAwZp8QCY4+Pyq03/UhH6oIoGP4og4cEFnPsKnehxezeasFsmdLZcYIhc+kefe0u4FF4rP9TbCAErftS0AkrYnuGI+s8jNtuHGQGIxrRA1US1DZ24+1wSmHRPH2IONwIIoc8HcGvks+83+gVJHqUPGg5ofN80GOkLsBLwVDJiplgA+YdQXUGjz7elgbDriKbRqcriclcooS0HyjBOGDrNIyfeyJoqiUKlOROw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=x9jAxnYm; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::649; helo=mail-pl1-x649.google.com; envelope-from=39bsizwykdis7tp2yrv33v0t.r310x29c44r-sta0x787.3e0pq7.36v@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=x9jAxnYm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::649; helo=mail-pl1-x649.google.com; envelope-from=39bsizwykdis7tp2yrv33v0t.r310x29c44r-sta0x787.3e0pq7.36v@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XPdTM4tzhz2yNc for ; Fri, 11 Oct 2024 05:24:55 +1100 (AEDT) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-20c94c1f692so4778105ad.1 for ; Thu, 10 Oct 2024 11:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728584693; x=1729189493; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:from:to:cc:subject:date :message-id:reply-to; bh=yUMe47Ku2d+lU53n+UV6eA4G9zH9pOaBnB7PUsg7n0E=; b=x9jAxnYmIJ2RPUnUqbFnjU52Hx7OQ4aT6MR27Mm/sCHrxwYgxhP69oCT5MDUdsvFOP xSermcvY42chBd1LzrBvKn1pvvw6JHRZWuxdMtzi0lLvk2hpJqBxKlyO5N/vlFPH2sFp 1dAQGs9kLJwmBpSVdszM4zyQw2N9SURjVD5T2tc3SAu/OuX809CS+4T3xNNEgiBYUQvO A+74ltMRr8KB2x36kUiQ6nWLGYwHxA+LxxG5o675vafpII6WK7hfwgduJAmIufXSQx86 x77lBnYpXOFGeJOjzsI59kjslZcFEq3bITW4uo2HydUzN5BfVsnjwObXHEL8jXb6fZnp fDHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728584693; x=1729189493; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yUMe47Ku2d+lU53n+UV6eA4G9zH9pOaBnB7PUsg7n0E=; b=gMg/xv8mGUsfGqJVGeBwrkulP++b7PedpjLteKp2lSFRILNUMWn42eNaOcpZKWjEMm JoTtMQk20ry+gzGcQ7RhkQEVApjx4CRAAIAt9CUYOU1mpoCixsw1zLdkUwN2NkACSG6t Y30+WOOb2trt6ZOmIRKAFyo7JYgTJXoMcTQYwtfiwblPjl/q+/n5bFNCDfS2rNrc4+Bj 4qPY1pNDNRIq9quTPS9GBP+2K//ooxSqA5drNN92nlZ/6Rs38y0Wjl8cLNJhwMrLVGuU UxpDpzkftXeqSvdye+eQs5Ud/HGRINlWKTqExerycKxBbvSh0UpabBeBLtlrm08s+Gxb 53Ag== X-Forwarded-Encrypted: i=1; AJvYcCUGuUtBV08ZhvtvEuSuhOmeCvPZsGwTXni0Cu7/cN/+X/zqWvH1v43ArEeoInuu850ImYOWHV4iYs4RtkU=@lists.ozlabs.org X-Gm-Message-State: AOJu0YyrbNahJvcTm5kGGp5Amb8izb5jxNg/gkSaKmpJVSk8Y+TM78bH hMJ6NLwQEQLf/ucxlORcPtPc4c+LLC+8hMK8ev1ElrtADgjwhF3oMLO7qqwW4J5H31AAAv3eYsc XLg== X-Google-Smtp-Source: AGHT+IHgBvu4/6UpOEaDnS659CK1Rn1/E5r8mTk00ZsUtMRUIXJafj8Ignnkw5WxXqtPYIrr50vXY4UIGHU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:902:ff02:b0:205:58ee:1567 with SMTP id d9443c01a7336-20c80362278mr43175ad.0.1728584692824; Thu, 10 Oct 2024 11:24:52 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 10 Oct 2024 11:23:04 -0700 In-Reply-To: <20241010182427.1434605-1-seanjc@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Message-ID: <20241010182427.1434605-3-seanjc@google.com> Subject: [PATCH v13 02/85] KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, "=?UTF-8?q?Alex=20Benn=C3=A9e?=" , Yan Zhao , David Matlack , David Stevens , Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Allow passing a NULL @page to kvm_release_page_{clean,dirty}(), there's no tangible benefit to forcing the callers to pre-check @page, and it ends up generating a lot of duplicate boilerplate code. Reviewed-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 4b659a649dfa..2032292df0b0 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3179,7 +3179,7 @@ static void kvm_set_page_accessed(struct page *page) =20 void kvm_release_page_clean(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; =20 kvm_set_page_accessed(page); @@ -3204,7 +3204,7 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_clean); =20 void kvm_release_page_dirty(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; =20 kvm_set_page_dirty(page); --=20 2.47.0.rc1.288.g06298d1525-goog