From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE956CFC5EB for ; Thu, 10 Oct 2024 18:32:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XPdXL6zMhz3cT0; Fri, 11 Oct 2024 05:27:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::549" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728584850; cv=none; b=dH8ylQzS4398QQ0CDJCuFaFPb9FOlU1tAo2gFQZosHf0tedfhlUDEVNs0UUF+rYNIDTGMoP9MOXZNTZwSgqBHAqDv5zQ3oRMR4fLGH/WCz9ovdwkUxd6aqkB//lWDVZBsOgJXYfZe3qpQ66spMbGku0G6jT5dBWHoq3VDBv+zZ5hZ3OhvAxsh6dHDI5MrJqdqHgfispXyTURIdMxE2k4HId/Oi0IyKwEHPaP3ogBiqYt8GgORe/HjNBsoDGiDkLGyh86UK1aQtHzUM/RDYq73quwQ+vypLc75dN6u6j0zUa+7P+/1Q3KvA6s2bjlxLNdSYaDs2P5+6FTLUNpaDScfg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1728584850; c=relaxed/relaxed; bh=t4DEWxyHdS8FH8bmPlxV35CavnLWtw4MDWneo+GIfaw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fnUbGcbJGVrbBgNGUis8eik+7CcMmgafNTyrhJfQ6pCyjgU9koFbWuZzSFVq4UHqJ47As/CzITD4CgDbTAe0Yo+2Gl5jF3h5POE0wOI2wEYuCQbUGckxMOrX2bc3fiKMMSQUZVunGVEl5PqGMAsEU5pcpik6GmLz7jRuE+p3/wEwzrG3hz1WiPeLr5wsezM6J85CrRuQpiWjGrOT73sNZ9K3GgGuBoL3CZCCH/4Gx+sTEaM1yWWcmD438Q5WgBoDQZORIYwbHMT/zt1QjlJRk8L1R0fbhHsQC8vkGbWjvkhuDGjmg1Z/nYlBlUb5S6x9El4WKS3HHNT5NfCtuKJFMw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=kGsgBVDH; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::549; helo=mail-pg1-x549.google.com; envelope-from=3jhwizwykdccvhdqmfjrrjoh.frpolqxassf-ghyolvwv.rcodev.ruj@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=kGsgBVDH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::549; helo=mail-pg1-x549.google.com; envelope-from=3jhwizwykdccvhdqmfjrrjoh.frpolqxassf-ghyolvwv.rcodev.ruj@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XPdXL0VMyz3cSv for ; Fri, 11 Oct 2024 05:27:29 +1100 (AEDT) Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-7e9f9a927a5so1044665a12.2 for ; Thu, 10 Oct 2024 11:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728584848; x=1729189648; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=t4DEWxyHdS8FH8bmPlxV35CavnLWtw4MDWneo+GIfaw=; b=kGsgBVDHch/8PYpEaPcGl90fM2nvF3opZsaG/RkzHD/uTu72PtN+iHx5ZFl7MqwdN3 0ww9WznPjOXV6+rMKKWbR0xDwnn1MuMtFoemAJGbsXQWtqaKy9K2TzJAfqFMQXKGo1HB eDPckaQQQP8O8yNWuYQQHXdVgvFcAMWVjcQWL5tZZUXa1WexyfJ77eL4GwE5Sydf+y4K 4FhK8Z4LSJNxdkvnjeW50y7Rl2DnzGUe3aJNLjdqgj0qiwH641y57yFUORL2zy243mIh RW5+SSuKCCNEZPtCJuE//Ce9/cg9XI2+AM+WyXrNApRLbfN5mT6FhVpbIizrINaM8pv/ 4veQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728584848; x=1729189648; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t4DEWxyHdS8FH8bmPlxV35CavnLWtw4MDWneo+GIfaw=; b=qJjEnDg3bJt3bSHiCob401WXXmmj4UvZk96593PhvpEI+eY5ezoiQmuY1uH3ZrSqJK X9YHfX+rcYEjrHKSL4UeySxvy/bKl/VNHD/ZMBm1s2txMMqJFwiWcmO2IlgKhHyXtS+e qaraNX3W3WmtfhQARXPC3vwPtx5H0BaG6f/8Lk0uweXFOBWw9Ox6WJySjafiJAqaqAFC 5H/puEICcWlhyEZT8irmL9mUaakYhUKK+/LYA4uJnaUlssEbnV3LYA06mrwNGh4ttNlz +mxo9+AE+1SgT1Y5yGI6M5Q7F5BkLwmisf5QEiaUoVawlyWo9MrsyFY/2hTzqGr1voFc G5kA== X-Forwarded-Encrypted: i=1; AJvYcCW+7FzTEWSJnV2RFf6BRUhiZIcNWk2530ZnpUQ+9Y9LRTkEs9uuUYB4sFogxH+Fm2nGzE1BiRFn7YDsZNA=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yw22YjOFos45EJnzFMClRgrf/Dp1U22Xws3t3N/xY4Zu3k1GXLa y1DcJtZijzqThOrRdU3qF4c/fjT8KFAhafLfM+skJTn6erl2b8xuHFvgBw3I6wG6Wh23SusVsUN ACg== X-Google-Smtp-Source: AGHT+IHU1NaHt28BJAfE9+Eihx21gIRaHWD3wJUzNDiwOfeaS4l1n7K6hdxyKTp49hAFCJqVbhS/fDDFwRQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a63:2545:0:b0:7e6:b4dd:fc0d with SMTP id 41be03b00d2f7-7ea535b0baemr20a12.7.1728584846518; Thu, 10 Oct 2024 11:27:26 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 10 Oct 2024 11:24:15 -0700 In-Reply-To: <20241010182427.1434605-1-seanjc@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Post: List-Subscribe: , , List-Unsubscribe: Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Message-ID: <20241010182427.1434605-74-seanjc@google.com> Subject: [PATCH v13 73/85] KVM: PPC: Remove extra get_page() to fix page refcount leak From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, "=?UTF-8?q?Alex=20Benn=C3=A9e?=" , Yan Zhao , David Matlack , David Stevens , Andrew Jones Content-Type: text/plain; charset="UTF-8" Don't manually do get_page() when patching dcbz, as gfn_to_page() gifts the caller a reference. I.e. doing get_page() will leak the page due to not putting all references. Signed-off-by: Sean Christopherson --- arch/powerpc/kvm/book3s_pr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c index d7721297b9b6..cd7ab6d85090 100644 --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c @@ -652,7 +652,6 @@ static void kvmppc_patch_dcbz(struct kvm_vcpu *vcpu, struct kvmppc_pte *pte) hpage_offset &= ~0xFFFULL; hpage_offset /= 4; - get_page(hpage); page = kmap_atomic(hpage); /* patch dcbz into reserved instruction, so we trap */ -- 2.47.0.rc1.288.g06298d1525-goog