From: kernel test robot <lkp@intel.com>
To: Eliav Farber <farbere@amazon.com>,
linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen@kernel.org,
maddy@linux.ibm.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@linutronix.de,
ebiederm@xmission.com, akpm@linux-foundation.org, bhe@redhat.com,
hbathini@linux.ibm.com, sourabhjain@linux.ibm.com,
adityag@linux.ibm.com, songshuaishuai@tinylab.org,
takakura@valinux.co.jp, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, kexec@lists.infradead.org
Cc: oe-kbuild-all@lists.linux.dev, jonnyc@amazon.com
Subject: Re: [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation
Date: Fri, 29 Nov 2024 10:46:18 +0800 [thread overview]
Message-ID: <202411291047.R9P698b2-lkp@intel.com> (raw)
In-Reply-To: <20241128201027.10396-2-farbere@amazon.com>
Hi Eliav,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eliav-Farber/kexec-Consolidate-machine_kexec_mask_interrupts-implementation/20241129-041259
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20241128201027.10396-2-farbere%40amazon.com
patch subject: [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20241129/202411291047.R9P698b2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411291047.R9P698b2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411291047.R9P698b2-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
kernel/kexec_core.c: In function 'machine_kexec_mask_interrupts':
>> kernel/kexec_core.c:1085:24: error: implicit declaration of function 'irq_desc_get_chip' [-Werror=implicit-function-declaration]
1085 | chip = irq_desc_get_chip(desc);
| ^~~~~~~~~~~~~~~~~
>> kernel/kexec_core.c:1085:22: warning: assignment to 'struct irq_chip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1085 | chip = irq_desc_get_chip(desc);
| ^
>> kernel/kexec_core.c:1097:38: error: invalid use of undefined type 'struct irq_chip'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~
>> kernel/kexec_core.c:1097:51: error: implicit declaration of function 'irqd_irq_inprogress' [-Werror=implicit-function-declaration]
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~~~~~~~~~~~~~~~~~~
>> kernel/kexec_core.c:1097:76: error: invalid use of undefined type 'struct irq_desc'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~
kernel/kexec_core.c:1098:29: error: invalid use of undefined type 'struct irq_chip'
1098 | chip->irq_eoi(&desc->irq_data);
| ^~
kernel/kexec_core.c:1098:44: error: invalid use of undefined type 'struct irq_desc'
1098 | chip->irq_eoi(&desc->irq_data);
| ^~
kernel/kexec_core.c:1100:25: error: invalid use of undefined type 'struct irq_chip'
1100 | if (chip->irq_mask)
| ^~
kernel/kexec_core.c:1101:29: error: invalid use of undefined type 'struct irq_chip'
1101 | chip->irq_mask(&desc->irq_data);
| ^~
kernel/kexec_core.c:1101:45: error: invalid use of undefined type 'struct irq_desc'
1101 | chip->irq_mask(&desc->irq_data);
| ^~
kernel/kexec_core.c:1103:25: error: invalid use of undefined type 'struct irq_chip'
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ^~
kernel/kexec_core.c:1103:43: error: implicit declaration of function 'irqd_irq_disabled'; did you mean 'arch_irqs_disabled'? [-Werror=implicit-function-declaration]
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ^~~~~~~~~~~~~~~~~
| arch_irqs_disabled
kernel/kexec_core.c:1103:66: error: invalid use of undefined type 'struct irq_desc'
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ^~
kernel/kexec_core.c:1104:29: error: invalid use of undefined type 'struct irq_chip'
1104 | chip->irq_disable(&desc->irq_data);
| ^~
kernel/kexec_core.c:1104:48: error: invalid use of undefined type 'struct irq_desc'
1104 | chip->irq_disable(&desc->irq_data);
| ^~
cc1: some warnings being treated as errors
vim +/irq_desc_get_chip +1085 kernel/kexec_core.c
1075
1076 void machine_kexec_mask_interrupts(void)
1077 {
1078 unsigned int i;
1079 struct irq_desc *desc;
1080
1081 for_each_irq_desc(i, desc) {
1082 struct irq_chip *chip;
1083 int check_eoi = 1;
1084
> 1085 chip = irq_desc_get_chip(desc);
1086 if (!chip)
1087 continue;
1088
1089 if (IS_ENABLED(CONFIG_ARM64)) {
1090 /*
1091 * First try to remove the active state. If this fails, try to EOI the
1092 * interrupt.
1093 */
1094 check_eoi = irq_set_irqchip_state(i, IRQCHIP_STATE_ACTIVE, false);
1095 }
1096
> 1097 if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-29 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 20:10 [PATCH v3 0/2] Improve interrupt handling during machine kexec Eliav Farber
2024-11-28 20:10 ` [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation Eliav Farber
2024-11-29 2:46 ` kernel test robot [this message]
2024-11-29 4:30 ` kernel test robot
2024-11-28 20:10 ` [PATCH v3 2/2] kexec: Prevent redundant IRQ masking by checking state before shutdown Eliav Farber
2024-11-29 4:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411291047.R9P698b2-lkp@intel.com \
--to=lkp@intel.com \
--cc=adityag@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ebiederm@xmission.com \
--cc=farbere@amazon.com \
--cc=hbathini@linux.ibm.com \
--cc=jonnyc@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=songshuaishuai@tinylab.org \
--cc=sourabhjain@linux.ibm.com \
--cc=takakura@valinux.co.jp \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).