linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, fbarrat@linux.ibm.com,
	ukrishn@linux.ibm.com, manoj@linux.ibm.com,
	clombard@linux.ibm.com, vaibhav@linux.ibm.com
Subject: [PATCH 2/2] scsi/cxlflash: Deprecate driver
Date: Tue, 10 Dec 2024 16:40:55 +1100	[thread overview]
Message-ID: <20241210054055.144813-3-ajd@linux.ibm.com> (raw)
In-Reply-To: <20241210054055.144813-1-ajd@linux.ibm.com>

We intend to remove the cxlflash driver in an upcoming release. It is
already marked as Obsolete in MAINTAINERS.

The cxlflash driver has received minimal maintenance for some time, and
the CAPI Flash hardware that uses it is no longer commercially available.

Add a warning message on probe and change Kconfig to label the driver as
deprecated and not build the driver by default.

Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
---
 drivers/scsi/cxlflash/Kconfig | 6 ++++--
 drivers/scsi/cxlflash/main.c  | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/cxlflash/Kconfig b/drivers/scsi/cxlflash/Kconfig
index 5533bdcb0458..c424d36e89a6 100644
--- a/drivers/scsi/cxlflash/Kconfig
+++ b/drivers/scsi/cxlflash/Kconfig
@@ -4,10 +4,12 @@
 #
 
 config CXLFLASH
-	tristate "Support for IBM CAPI Flash"
+	tristate "Support for IBM CAPI Flash (DEPRECATED)"
 	depends on PCI && SCSI && (CXL || OCXL) && EEH
 	select IRQ_POLL
-	default m
 	help
+	  The cxlflash driver is deprecated and will be removed in a future
+	  kernel release.
+
 	  Allows CAPI Accelerated IO to Flash
 	  If unsure, say N.
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 60d62b93d624..62806f5e32e6 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -3651,6 +3651,8 @@ static int cxlflash_probe(struct pci_dev *pdev,
 	int rc = 0;
 	int k;
 
+	dev_err_once(&pdev->dev, "DEPRECATION: cxlflash is deprecated and will be removed in a future kernel release\n");
+
 	dev_dbg(&pdev->dev, "%s: Found CXLFLASH with IRQ: %d\n",
 		__func__, pdev->irq);
 
-- 
2.47.1



  parent reply	other threads:[~2024-12-10  5:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  5:40 [PATCH 0/2] Deprecate cxl and cxlflash drivers Andrew Donnellan
2024-12-10  5:40 ` [PATCH 1/2] cxl: Deprecate driver Andrew Donnellan
2024-12-10 14:59   ` Frederic Barrat
2024-12-11 23:23   ` kernel test robot
2024-12-10  5:40 ` Andrew Donnellan [this message]
2024-12-10 15:00   ` [PATCH 2/2] scsi/cxlflash: " Frederic Barrat
2025-01-01  9:00 ` [PATCH 0/2] Deprecate cxl and cxlflash drivers Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210054055.144813-3-ajd@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=clombard@linux.ibm.com \
    --cc=fbarrat@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=manoj@linux.ibm.com \
    --cc=ukrishn@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).