[PATCH v2] macintosh: declare ctl_table as const

[PATCH v2] macintosh: declare ctl_table as const

[Luis Felipe Hernandez]

Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
ctl_table"), the sysctl registration API allows struct ctl_table variables
to be placed into read-only memory.

mac_hid_files is registered as a sysctl table and should be treated as
read-only. By declaring the mac_hid_files structure as const, we ensure
that it cannot be accidentally modified. This change improves safety.

Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
Suggested-by: Ricardo B. Marliere <rbm@suse.com>
Reviewed-by: Ricardo B. Marliere <rbm@suse.com>
Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
---
Changes in v2:
  * Remove redundant commit reference
  * Fix Suggested-by tags
---
 drivers/macintosh/mac_hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index b461b1bed25b2df106ecf612b82efaedf69f62b0..369d72f59b3c10869bc914f31e7dcb73e029ef7f 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -215,7 +215,7 @@ static int mac_hid_toggle_emumouse(const struct ctl_table *table, int write,
 }
 
 /* file(s) in /proc/sys/dev/mac_hid */
-static struct ctl_table mac_hid_files[] = {
+static const struct ctl_table mac_hid_files[] = {
 	{
 		.procname	= "mouse_button_emulation",
 		.data		= &mouse_emulate_buttons,

---
base-commit: fdb298fa865b0136f7be842e6c2e6310dede421a
change-id: 20241217-constify_ctl_table-881fcffc8804

Best regards,
-- 
Luis Felipe Hernandez <luis.hernandez093@gmail.com>

Re: [PATCH v2] macintosh: declare ctl_table as const

[Madhavan Srinivasan]

On Tue, 17 Dec 2024 21:55:41 -0500, Luis Felipe Hernandez wrote:
> Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
> ctl_table"), the sysctl registration API allows struct ctl_table variables
> to be placed into read-only memory.
> 
> mac_hid_files is registered as a sysctl table and should be treated as
> read-only. By declaring the mac_hid_files structure as const, we ensure
> that it cannot be accidentally modified. This change improves safety.
> 
> [...]

Applied to powerpc/next.

[1/1] macintosh: declare ctl_table as const
      https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=e834166822a3c9fb403411c898367df8dabf973c 

Thanks