From: Yazen Ghannam <yazen.ghannam@amd.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts
Date: Tue, 17 Dec 2024 16:55:45 -0500 [thread overview]
Message-ID: <20241217215545.GB1121691@yaz-khff2.amd.com> (raw)
In-Reply-To: <20241217135358.9345-9-ilpo.jarvinen@linux.intel.com>
On Tue, Dec 17, 2024 at 03:53:58PM +0200, Ilpo Järvinen wrote:
> Only part of the AER diagnostic printouts use "AER:" prefix because
> they use low-level pci_printk() directly to allow selecting level.
>
> Add "AER:" prefix to lines that are printed with pci_printk().
>
Can we please include the "HW_ERR" prefix also? IMO, it would make the
kernel messages more consistent if all hardware error info had it.
Thanks,
Yazen
next prev parent reply other threads:[~2024-12-17 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 13:53 [PATCH v7 0/8] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 1/8] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 2/8] PCI: Move TLP Log handling to own file Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 3/8] PCI: Make pcie_read_tlp_log() signature same Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 4/8] PCI: Use unsigned int i in pcie_read_tlp_log() Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 5/8] PCI: Store # of supported End-End TLP Prefixes Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 6/8] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2024-12-17 15:36 ` Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 7/8] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 8/8] PCI/AER: Add prefixes to printouts Ilpo Järvinen
2024-12-17 21:55 ` Yazen Ghannam [this message]
2024-12-18 14:15 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217215545.GB1121691@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).