From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4643DE77188 for ; Fri, 3 Jan 2025 11:17:39 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YPgz566QCz2xQ8; Fri, 3 Jan 2025 22:17:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.176.79.56 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1735903057; cv=none; b=BOhQaIW4LIR0Jz8+TnIKE4edSV94LhHrd1+8N30O8KlQx7wIUW87W/b0SoVnhnT3Zt0pOVwUr6Mgb/0UXC9apR4agw0p1MZCjaQW9GWlkCyfUJbWAz5j+ED+dyu3YdnP9FLYt3b47202qtwkdKyFJSNX526jZAJWZYNgPJOBszgCNbMyyXJzrDd5AIkQpjt/Y33ltthOO1gVrymA5abaTy5rdAT73WSoVLXr5tecA32P1OwhTl8YAw/fCe0fY1zg9sUpfnbaly/ZrfsX/vBn7nsI+qB91YD95OY8wVNggr285LmfHNDF4YowXEDjupwabkCRFCbwp7bwOK++UyqIww== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1735903057; c=relaxed/relaxed; bh=Aq48p+m41K3ezDIynwlebgPMap9fDoRlnHk8CyL6OTY=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EyHpt/YkkZPsYW1vzLouyESTFn1PNgAUEDnYXWonuA2uLaZtkBPvjqVHjUL9ESX0QZEOKbjo4zmSYrxIyV/IzYWLsa8LXzGJJk0/kNvU5Xlx1qexuJf8Vj9uEZxhnyxJn0ji3cviPoRjIolxio30cRbl1DbOLZcWaMp+EMQbxoL4FuhL/B85v/q8RDzxCakpR4f7FGPWdwc1GWDENNZGN0axHf0aOsjjdT8E7zUcFacZKvD5RdBA1l8fXqc9KymD4YenAy9w/Al00XMU8A+wu7GNh2kwEz1XofR13dhbDnwJAu1n5TrU8Dou6jRUxSP1wLxvAb7i4jBny15Dbds7Vw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass (client-ip=185.176.79.56; helo=frasgout.his.huawei.com; envelope-from=jonathan.cameron@huawei.com; receiver=lists.ozlabs.org) smtp.mailfrom=huawei.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=185.176.79.56; helo=frasgout.his.huawei.com; envelope-from=jonathan.cameron@huawei.com; receiver=lists.ozlabs.org) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YPgz46gFqz2x9j for ; Fri, 3 Jan 2025 22:17:36 +1100 (AEDT) Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YPgxM1w8zz6M4KP; Fri, 3 Jan 2025 19:16:07 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6F8691406AC; Fri, 3 Jan 2025 19:17:34 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 3 Jan 2025 12:17:34 +0100 Date: Fri, 3 Jan 2025 11:17:32 +0000 From: Jonathan Cameron To: Atharva Tiwari CC: Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , , , Subject: Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices Message-ID: <20250103111732.00003ab3@huawei.com> In-Reply-To: <20241227071910.1719-1-evepolonium@gmail.com> References: <20241227071910.1719-1-evepolonium@gmail.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To frapeml500008.china.huawei.com (7.182.85.71) On Fri, 27 Dec 2024 12:49:10 +0530 Atharva Tiwari wrote: > Log an error message in `find_device_iter' > when the system cannot handle more error devices. Needs a statement of 'why' Jonathan > > Signed-off-by: Atharva Tiwari > --- > drivers/pci/pcie/aer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index 34ce9f834d0c..04743617202e 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data) > /* List this device */ > if (add_error_device(e_info, dev)) { > /* We cannot handle more... Stop iteration */ > - /* TODO: Should print error message here? */ > + pr_err("PCI: Unable to handle additional error devices\n"); > return 1; > } >