* [PATCH] PCI/AER:Add error message when unable to handle additional devices
@ 2024-12-27 7:19 Atharva Tiwari
2025-01-03 11:17 ` Jonathan Cameron
2025-01-03 13:20 ` Atharva Tiwari
0 siblings, 2 replies; 4+ messages in thread
From: Atharva Tiwari @ 2024-12-27 7:19 UTC (permalink / raw)
Cc: evepolonium, Mahesh J Salgaonkar, Oliver O'Halloran,
Bjorn Helgaas, linuxppc-dev, linux-pci, linux-kernel
Log an error message in `find_device_iter'
when the system cannot handle more error devices.
Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
drivers/pci/pcie/aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 34ce9f834d0c..04743617202e 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
/* List this device */
if (add_error_device(e_info, dev)) {
/* We cannot handle more... Stop iteration */
- /* TODO: Should print error message here? */
+ pr_err("PCI: Unable to handle additional error devices\n");
return 1;
}
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices
2024-12-27 7:19 [PATCH] PCI/AER:Add error message when unable to handle additional devices Atharva Tiwari
@ 2025-01-03 11:17 ` Jonathan Cameron
2025-01-03 13:20 ` Atharva Tiwari
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-01-03 11:17 UTC (permalink / raw)
To: Atharva Tiwari
Cc: Mahesh J Salgaonkar, Oliver O'Halloran, Bjorn Helgaas,
linuxppc-dev, linux-pci, linux-kernel
On Fri, 27 Dec 2024 12:49:10 +0530
Atharva Tiwari <evepolonium@gmail.com> wrote:
> Log an error message in `find_device_iter'
> when the system cannot handle more error devices.
Needs a statement of 'why'
Jonathan
>
> Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
> ---
> drivers/pci/pcie/aer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 34ce9f834d0c..04743617202e 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
> /* List this device */
> if (add_error_device(e_info, dev)) {
> /* We cannot handle more... Stop iteration */
> - /* TODO: Should print error message here? */
> + pr_err("PCI: Unable to handle additional error devices\n");
> return 1;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PCI/AER:Add error message when unable to handle additional devices
2024-12-27 7:19 [PATCH] PCI/AER:Add error message when unable to handle additional devices Atharva Tiwari
2025-01-03 11:17 ` Jonathan Cameron
@ 2025-01-03 13:20 ` Atharva Tiwari
2025-01-03 16:32 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Atharva Tiwari @ 2025-01-03 13:20 UTC (permalink / raw)
To: evepolonium
Cc: bhelgaas, linux-kernel, linux-pci, linuxppc-dev, mahesh, oohall
i completed the todo on line 886 thats why
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI/AER:Add error message when unable to handle additional devices
2025-01-03 13:20 ` Atharva Tiwari
@ 2025-01-03 16:32 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-01-03 16:32 UTC (permalink / raw)
To: Atharva Tiwari
Cc: bhelgaas, linux-kernel, linux-pci, linuxppc-dev, mahesh, oohall
On Fri, 3 Jan 2025 18:50:35 +0530
Atharva Tiwari <evepolonium@gmail.com> wrote:
> i completed the todo on line 886 thats why
>
It is a question, not a todo. So if you wish to
make the change you need to discuss why the answer to that
question was 'yes it makes sense to print an error message here'.
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-03 16:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-27 7:19 [PATCH] PCI/AER:Add error message when unable to handle additional devices Atharva Tiwari
2025-01-03 11:17 ` Jonathan Cameron
2025-01-03 13:20 ` Atharva Tiwari
2025-01-03 16:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).