From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1588C02190 for ; Fri, 31 Jan 2025 16:26:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Yl1Vq10X5z30ML; Sat, 1 Feb 2025 03:26:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1738340803; cv=none; b=KMIKTIaLxc+NOaVIuzknV2DEurznnEA+WBareYXS/BmgsVAdMXSKqj2hSqqIveY1UbCqjRQR/FlRL9mvSocrC71zz25M76DPW4PN+pOUxBPLdULk96Jr+hdrz2ytQjnxy3Xr138+4/N5UcfIp8l1sy9dgn2PazrCA/k53oTP4qDYmOJ7e4/+K+nlSpueJM95KT+AC1ds/KfaT9BN79w11/ZHk845zK2s9gTdzaoVSJedqUhdPtJcyF5Fjnl3xbIKMpj6ad6jR8wVprnyuNFROWlP363iuOWwh+PR9f81AYrZ/PqTaFCFS1tiw2FCdK1rYq8Dji4ih+7e5xpsHI4KvA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1738340803; c=relaxed/relaxed; bh=I1uj/AIFvW3TkvVDVcjXPUH5/EYWEwV4qgbFUX28yB8=; h=Date:From:To:Cc:Subject:Message-ID:References:Mime-Version: Content-Type:Content-Disposition:In-Reply-To; b=jNDAAr+0Dl5k305MY/INivQNDEI9j2UPZ8F1WWpm/Oy4hTasCjrUPQjpcztNGwazWrKyC15PlvbWnoNqCb/fXwCnuIfShqZfR12CZhB/rGYxa/23aZfPb3lS3scAq5SteMw58uOoq2msADs4Gi15jojEWPWDQJwccqWdyVbAE0pHIa6NGUbt03E96pW+h3lor2CXO7szVdROUt6rKburDxJY846+ugSs2BDtrRGxYvJxmSqgx7r79Z3pZslqz5o9CUKQPOrCIJMFSUVom4WNB+R6V7Hfz/ibyRzZOQEA58qAlJwyOjdXkIDlwX1ighurn7uH6MdiAoePN8rFjztniw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.crashing.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=lists.ozlabs.org) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4Yl1Vp1tBCz30Kd for ; Sat, 1 Feb 2025 03:26:42 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 50VGPe0x026344; Fri, 31 Jan 2025 10:25:40 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 50VGPdxQ026339; Fri, 31 Jan 2025 10:25:39 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 31 Jan 2025 10:25:38 -0600 From: Segher Boessenkool To: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function Message-ID: <20250131162538.GZ20626@gate.crashing.org> References: X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Hi! > +static void microwatt_idle(void) > +{ > + if (!prep_irq_for_idle()) > + return; > + > + __asm__ __volatile__ ("wait"); > +} All asm without outputs is always implicitly volatile (if it wasn't, it could always be transfirmed whatever way you want, like, optimised away completely). It can still be useful for documentation purposes of course, but here it is the other way around really, it is just cargo cult :-( Segher